Add device motion to MCTS checking

RESOLVED FIXED

Status

Firefox OS
Certification Suite
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: atsai, Assigned: atsai)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

54 bytes, text/x-github-pull-request
askeing
: review+
oo[oouyang]
: review+
Details | Review | Splinter Review
(Assignee)

Description

3 years ago
According discuss with gonk team, we are now using deviceMotion for tracking the orientation of devices. Therefore, I suggest to use deviceMotion for testing instead of deviceOrientation.

https://developer.mozilla.org/en-US/docs/Web/Events/devicemotion
(Assignee)

Comment 1

3 years ago
It seems we don't need to replace device orientation. Both of them should work as expect.
Summary: use deviceMotion to replace deviceOrientation → Add device motion to MCTS checking
(Assignee)

Updated

3 years ago
Assignee: nobody → atsai
(Assignee)

Comment 3

3 years ago
Created attachment 8595778 [details] [review]
add device_motion checking
Attachment #8595778 - Flags: review?(oouyang)
Attachment #8595778 - Flags: review?(fyen)

Comment 4

3 years ago
Comment on attachment 8595778 [details] [review]
add device_motion checking

LGTM
Attachment #8595778 - Flags: review?(oouyang) → review+
(Assignee)

Comment 5

3 years ago
merged
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Attachment #8595778 - Flags: review?(fyen) → review+
You need to log in before you can comment on or make changes to this bug.