1147786 - [Flame][Homescreen]When you quickly double-click "X" icon to delete a collection, two "Delete" boxs pop up.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[SandKing]

Attachment: Bug log: logcat_0501.txt

[1.Description]:
[Flame][v2.2&3.0][Homescreen]When you quickly double-click  "X" icon on homescreen editing mode to delete a collection, two collections have been selected.
See Video: "0501.mp4"
See log:"logcat_0501.txt"
Found Time:05:01

[2.Testing Steps]: 
1. Long press a collection to invoke "Edit" mode.
2. Quickly double-click  "X" icon of the collection.


[3.Expected Result]: 
2. Only one collection has been selected.

[4.Actual Result]: 
2. Two collections have been selected.

[5.Reproduction build]: 
Flame 2.2 (Affected)
Build ID               20150325162500
Gaia Revision          2d42a7c1d99472780e3aeb2e16d7cb0a4adbd222
Gaia Date              2015-03-25 20:46:52
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/ebb742bfe1a4
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150325.200218
Firmware Date          Wed Mar 25 20:02:30 EDT 2015
Bootloader             L1TC000118D0

Flame 3.0: (Affected)
Build ID               20150325160204
Gaia Revision          508b8d48fb5ecf08bf0e5b4fef42bc48b770e7f2
Gaia Date              2015-03-25 16:54:53
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/f40ee067d081
Gecko Version          39.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150325.191758
Firmware Date          Wed Mar 25 19:18:07 EDT 2015
Bootloader             L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
Free Test

Comment 1

[SandKing]

Attachment: Bug video: 0501.MP4

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] Cwiiis:bug1147786-homescreen-delete-multiple-dialogs > mozilla-b2g:master

Comment 3

[Chris Lord [:cwiiis]]

Comment on attachment 8584489 [details] [review]
[gaia] Cwiiis:bug1147786-homescreen-delete-multiple-dialogs > mozilla-b2g:master

I couldn't actually replicate, but I modified grid to just send the signal twice and indeed witnessed two dialogs. I've fixed the issue in verticalhome and added a unit test for it.

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8584489 [details] [review]
[gaia] Cwiiis:bug1147786-homescreen-delete-multiple-dialogs > mozilla-b2g:master

The code looks fine to me. Please fix the lint error and reland.

apps/verticalhome/test/unit/app_manager_test.js: line 40, col 9, 'dialogStub' is defined but never used. (ERROR)

Comment 5

[GitHub Autolander Bot]

http://docs.taskcluster.net/tools/task-graph-inspector/#M31lXx7qSBKs_P_LOJugAA

The pull request failed to pass integration tests. It could not be landed, please try again.

Comment 6

[Kevin Grandon :kgrandon]

Tests look fine to me, I think this was just some TC problems which we are working on.

In master: https://github.com/mozilla-b2g/gaia/commit/72d400bc43c7221210b9bf0c8dedafa8775ea5db

Comment 7

[Elie]

This issue has been verified successfully on latest build of Flame 3.0 with the same steps in comment 0
Flame 3.0:
Build ID               20150329010203
Gaia Revision          67ad91f3f660b1f16b354ee4c5159ddc5a74d149
Gaia Date              2015-03-28 10:02:40
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/385840329d91
Gecko Version          39.0a1
Device Name            flame
Firmware(Release)      4.4.2
Reproduce rate         0/5

Comment 8

[Norry.L.F(Leave from Mozilla)]

Hi Kevin,

This bug has been fixed on master, but not yet on flame v2.2. Will it be fixed on v2.2? 

Thanks:)

Comment 9

[Kevin Grandon :kgrandon]

(In reply to Norry.L.F from comment #8)
> This bug has been fixed on master, but not yet on flame v2.2. Will it be
> fixed on v2.2? 

I don't know, do we have to block to uplift?

Comment 10

[Gregor Wagner [:gwagner]]

Not blocking since the user impact is acceptable. Lets go the uplift approval way if we want this in 2.2