1147790 - [Email]The signature can't be added to mail automatically when you share a URL to Email.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Lance（leave from Mozilla）]

Attachment: logcat_1658.txt

[1.Description]:
[Nexus 5 v2.2 & v3.0][Flame v2.2][Email]When you view a website, then share it to Email, the Email signature can't be added in email.
Found time:16:58
See attachment:1658.mp4 and logcat_1658.txt

[2.Testing Steps]: 
Prerequisite: You have log in Email account.
1.Launch Browser.
2.View a website.
3.Tap Menu icon, then share it to Email.

[3.Expected Result]: 
3.The signature should be added automatically.

[4.Actual Result]: 
3.The Email edit page does not have the signature.

[5.Reproduction build]: 
Nexus 5_2.2 version(Affected):
Build ID               20150325162500
Gaia Revision          2d42a7c1d99472780e3aeb2e16d7cb0a4adbd222
Gaia Date              2015-03-25 20:46:52
Gecko Revision         https://hg.mozilla.org/releases/mozilla-

b2g37_v2_2/rev/ebb742bfe1a4
Gecko Version          37.0
Device Name            hammerhead
Firmware(Release)      5.0
Firmware(Incremental)  eng.cltbld.20150325.200112
Firmware Date          Wed Mar 25 20:01:26 EDT 2015
Bootloader             HHZ12d

Nexus 5_3.0 version(Affected):

Build ID               20150325160204
Gaia Revision          508b8d48fb5ecf08bf0e5b4fef42bc48b770e7f2
Gaia Date              2015-03-25 16:54:53
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/f40ee067d081
Gecko Version          39.0a1
Device Name            hammerhead
Firmware(Release)      5.0
Firmware(Incremental)  eng.cltbld.20150325.192549
Firmware Date          Wed Mar 25 19:26:05 EDT 2015
Bootloader             HHZ12d

Flame 2.2 version(Affected):
Build ID               20150325162500
Gaia Revision          2d42a7c1d99472780e3aeb2e16d7cb0a4adbd222
Gaia Date              2015-03-25 20:46:52
Gecko Revision         https://hg.mozilla.org/releases/mozilla-

b2g37_v2_2/rev/ebb742bfe1a4
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150325.200218
Firmware Date          Wed Mar 25 20:02:30 EDT 2015
Bootloader             L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
Free Test

[8.Note]
The bug still exist in Flame 2.2.

Comment 1

[Lance（leave from Mozilla）]

Attachment: 1658.MP4

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

Ah yeah, the compose-activity logic clobbers the body if a URL is provided or if a body payload is explicitly provided.  It should instead be prepending its contents so the signature doesn't get nuked.

Comment 3

[Teri Wen [:twen]]

Not a blocking bug, set tracking for backlog.

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] rsajdok:bug#1147790 > mozilla-b2g:master

Comment 5

[James Burke [:jrburke]]

Comment on attachment 8588461 [details] [review]
[gaia] rsajdok:bug#1147790 > mozilla-b2g:master

It was tempting to suggest fixing bug 1150829 by setting a property on the composeCard that indicated there was body content set by the activity entry point, but let's wait for the UX call in that bug first.

Thank you for the fix!

Comment 6

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/c710bac533b76635161315bf907d004e000549cb

Comment 7

[Shally Li（leave from Mozilla）]

This bug has been verified as pass on latest Nightly build of Flame v3.0 and Nexus 5 v3.0 by the STR in Comment 0.

Actual results: The signature will be added automatically when sharing a URL from Browser.
See attachment: verified_v3.0.mp4
Reproduce rate: 0/5

-----------------------------------------------------------------------------
Device: Flame 3.0 build(Pass)
Build ID               20150505010204
Gaia Revision          70077825aab2c7a79611befb40a5fe7e610d5443
Gaia Date              2015-05-04 18:09:33
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/102d0e9aa9e1
Gecko Version          40.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150505.043622
Firmware Date          Tue May  5 04:36:34 EDT 2015
Bootloader             L1TC000118D0

Device: Nexus 5 v3.0 build (Pass)
Build ID               20150505160203
Gaia Revision          42dc5f02a9df006b129824cd9bffa93cab937ab2
Gaia Date              2015-05-05 11:06:17
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/5907a8eca521
Gecko Version          40.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150505.192812
Firmware Date          Tue May  5 19:28:29 EDT 2015
Bootloader             HHZ12f

-------------------------------------------------------------
Add "verifyme" for v2.2 uplift & verification.

Comment 8

[Shally Li（leave from Mozilla）]

Attachment: verified_v3.0.mp4

Comment 9

[Shally Li（leave from Mozilla）]

The master has verified, clear verifyme keywords.