Closed Bug 1147806 Opened 5 years ago Closed 5 years ago

Content frame filtering is confused when profiling FxOS

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect)

x86
macOS
defect
Not set

Tracking

(firefox39 fixed)

RESOLVED FIXED
Firefox 39
Tracking Status
firefox39 --- fixed

People

(Reporter: paul, Assigned: vporof)

References

Details

Attachments

(4 files, 1 obsolete file)

Attached image screenshot
See screenshot (clock app is being profiled).

AppsService.js has nothing to do with the clock app.
I also see other things from the /dom/ directory.

If Gecko Platform Data is checked, then calls from the clock app show up.
Attached file profile.json
This is a combination of bug 1146533 and our `isContent` check not really knowing how to identify chrome code. Since those functions have chrome:// or app:// locations, they're filtered out.

https://dxr.mozilla.org/mozilla-central/source/browser/devtools/shared/profiler/tree-model.js?from=tree-model.js#255
Summary: FxOS / Perf++: JS calls are missing and wrong JS calls displayed → Content frame filtering is confused when profiling FxOS
Blocks: perf-tool-papercuts
No longer blocks: perf-tool-v2
Looks like all FxOS app code (on the simulator anyway) is linked to `app://{APP_ID}/` -- is this always the case? That should fix the content code displaying.

The other part is the AppsService.js looks like a file:///... link to the simulator extension, shouldn't that be a resource:// uri? I wonder if it's different because it's inside the B2G.app.
The function you're seeing included by default is a
> jar:file:///system/b2g/omni.ja!/components/AppsService.js:73
url.

I guess that even thought this is file, we should filter it out because it's actually inside a jar.
Assignee: nobody → vporof
Status: NEW → ASSIGNED
+1 to filtering jars, but not the case when I see the AppsServices file (attached is pic, we should add a way to copy URLs in call tree). It's a normal file URI.

I think this might have something to do with addons being packed or unpacked.
Attached patch v1 (obsolete) — Splinter Review
Attachment #8583853 - Flags: review?(jsantell)
Attached patch v1Splinter Review
qref
Attachment #8583853 - Attachment is obsolete: true
Attachment #8583853 - Flags: review?(jsantell)
Attachment #8583854 - Flags: review?(jsantell)
Firefox OS apps URLs start with app:// or http(s)://.
For AppsService.js, I would recommend to just filter out any URLs that include `/omni.ja!/`.
Attachment #8583854 - Flags: review?(jsantell) → review+
https://hg.mozilla.org/mozilla-central/rev/3a604f52306d
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 39
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.