Closed Bug 1147839 Opened 5 years ago Closed 5 years ago
Fix building installer on mingw
Although makensisu is not available for cross compiling, it's possible to build zip installer using mingw. There are only two small problems about package-manifest.in: - It always tries to include helper.exe for Windows builds, but it's only available in builds that use mknsisu. The attached patch makes it conditional. - MOZ_SHARED_ICU is always defined for Windows builds, even in builds with --without-intl-api option that disables icu. The attached patch fixes that. Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4194bc5cedeb
Attachment #8583786 - Flags: review?(mh+mozilla)
Attachment #8583786 - Flags: review?(mh+mozilla) → review+
Thanks for the review. https://hg.mozilla.org/integration/mozilla-inbound/rev/c8a0d3c15b93
Depends on: 1150967
You need to log in before you can comment on or make changes to this bug.