Closed
Bug 1147839
Opened 10 years ago
Closed 10 years ago
Fix building installer on mingw.
Categories
(Firefox Build System :: General, defect)
Tracking
(firefox40 fixed)
RESOLVED
FIXED
mozilla40
| Tracking | Status | |
|---|---|---|
| firefox40 | --- | fixed |
People
(Reporter: jacek, Assigned: jacek)
References
Details
Attachments
(1 file)
|
2.74 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
Although makensisu is not available for cross compiling, it's possible to build zip installer using mingw. There are only two small problems about package-manifest.in:
- It always tries to include helper.exe for Windows builds, but it's only available in builds that use mknsisu. The attached patch makes it conditional.
- MOZ_SHARED_ICU is always defined for Windows builds, even in builds with --without-intl-api option that disables icu. The attached patch fixes that.
Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4194bc5cedeb
Attachment #8583786 -
Flags: review?(mh+mozilla)
|
||
Updated•10 years ago
|
Attachment #8583786 -
Flags: review?(mh+mozilla) → review+
|
Assignee | |
Comment 1•10 years ago
|
||
Thanks for the review.
https://hg.mozilla.org/integration/mozilla-inbound/rev/c8a0d3c15b93
|
||
Comment 2•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•