Fix building installer on mingw.

RESOLVED FIXED in Firefox 40

Status

defect
RESOLVED FIXED
5 years ago
2 years ago

People

(Reporter: jacek, Assigned: jacek)

Tracking

Trunk
mozilla40
x86_64
Windows 7
Dependency tree / graph

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(1 attachment)

Posted patch fixSplinter Review
Although makensisu is not available for cross compiling, it's possible to build zip installer using mingw. There are only two small problems about package-manifest.in:

- It always tries to include helper.exe for Windows builds, but it's only available in builds that use mknsisu. The attached patch makes it conditional.

- MOZ_SHARED_ICU is always defined for Windows builds, even in builds with --without-intl-api option that disables icu. The attached patch fixes that.

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4194bc5cedeb
Attachment #8583786 - Flags: review?(mh+mozilla)
Attachment #8583786 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/c8a0d3c15b93
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.