Closed Bug 1147845 Opened 5 years ago Closed 5 years ago

Blocked downloads don't keep data on Unices other than Linux and Darwin

Categories

(Firefox :: Downloads Panel, defect)

39 Branch
All
FreeBSD
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 40
Tracking Status
firefox38 --- fixed
firefox39 --- fixed
firefox40 --- fixed

People

(Reporter: jbeich, Assigned: jbeich)

References

Details

Attachments

(1 file, 1 obsolete file)

User Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:39.0) Gecko/20100101 Firefox/39.0
Build ID: 20150325181557

Steps to reproduce:

1. Go to http://www.eicar.org/85-0-Download.html
2. Download eicar.com 68 Bytes


Actual results:

File is not saved. Download Panel says "Blocked: May contain a virus or spyware".


Expected results:

Still blocked but context menu has Unblock item. Same behavior as custom/non-official Linux builds or attachment 8572227 [details] [diff] [review].
Blocks: 1137909
Duplicate of this bug: 1147285
Attachment #8583890 - Flags: review?(jaws)
Component: Untriaged → Downloads Panel
Hardware: x86_64 → All
Comment on attachment 8583890 [details] [diff] [review]
Drop redundant check

Review of attachment 8583890 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/jsdownloads/src/DownloadIntegration.jsm
@@ +186,5 @@
>        return this.shouldKeepBlockedDataInTest;
>      }
>  
>      const FIREFOX_ID = "{ec8030f7-c20a-464f-9b0e-13a3a9e97384}";
>      let os = Services.appinfo.OS;

`os` is unused and can be removed.
Attachment #8583890 - Flags: review?(jaws) → review+
(In reply to Jan Beich from comment #2)
> I'm not sure how bug 1137909 comment 13 led to adding OS checks but IDs are
> different between apps or addons would break.
> 
> https://dxr.mozilla.org/comm-central/search?q=MOZ_APP_ID%3D&case=true

Thanks for the link, I missed that in the review as I thought the IDs were the same.
Removed |let os ...| and carrying over r+ per comment 3.
Attachment #8583890 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/be975e204f2a
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 40
Comment on attachment 8586821 [details] [diff] [review]
Drop redundant check

Approval Request Comment
[Feature/regressing bug #]: regression between patch revisions of the new feature in bug 1137909: attachment 8572227 [details] [diff] [review] vs. attachment 8572886 [details] [diff] [review]
[User impact if declined]: less feature parity with Linux <- blocked downloads cannot be unblocked on Tier3 platforms (Solaris and various BSDs)
[Describe test coverage new/current, TreeHerder]: m-c, m-i, Try in comment 2
[Risks and why]: Low, at worst (typos?) either errors in console or the feature enabled on non-Desktop platforms (Android, B2G, etc)
[String/UUID change made/needed]: None
Attachment #8586821 - Flags: approval-mozilla-beta?
Attachment #8586821 - Flags: approval-mozilla-aurora?
Comment on attachment 8586821 [details] [diff] [review]
Drop redundant check

We are about other platforms too, taking it. Should be in 38 beta 3.
Attachment #8586821 - Flags: approval-mozilla-beta?
Attachment #8586821 - Flags: approval-mozilla-beta+
Attachment #8586821 - Flags: approval-mozilla-aurora?
Attachment #8586821 - Flags: approval-mozilla-aurora+
Assignee: nobody → jbeich
You need to log in before you can comment on or make changes to this bug.