Closed Bug 1147860 Opened 8 years ago Closed 5 years ago

Intermittent communications/contacts/test/unit/search_test.js | Search mode Search by name & surname with trailing whitespaces - TypeError: imgLoader is undefined

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: RyanVM, Unassigned)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

New since the TC switch.

https://treeherder.mozilla.org/logviewer.html#?job_id=8056255&repo=mozilla-inbound - which is nice, Treeherder says it can't find the log. For a job from last night.
Flags: needinfo?(kgrandon)
Flags: needinfo?(jlal)
Mass clear of needinfo as lots of TC changes have recently been deployed. I am still tracking and working on getting these issues fixed, but will work with the most egregious offenders first. Flag me again if needed.
Flags: needinfo?(kgrandon)
Flags: needinfo?(jlal)
Pretty frequent still.
Flags: needinfo?(kgrandon)
Adrian - any chance you could look at this failing test? Thanks!
Flags: needinfo?(kgrandon) → needinfo?(hola)
Clearing the ni as Adrian is not working in FxOS right now.
Flags: needinfo?(hola)
Looking at <https://github.com/mozilla-b2g/gaia/commit/16346b060e481a4dad14c609ccb80631228ce7fb> it looks like we made imgLoader lazily-initialized and made _one_ of it uses conditional on it being initialized, but not the others.  Shouldn't the others just be conditional too?
Flags: needinfo?(ferjmoreno)
Comment on attachment 8693176 [details] [review]
[gaia] KevinGrandon:bug_1147860_contacts_search_test_intermittent > mozilla-b2g:master

I feel that this might only be a problem with the test because it tries to perform logic immediately after calling enterSearchMode(). One solution may be to have that return a promise which resolves after the files are loaded, and not starting the test until that promise is ready.

Fernando or Francisco, anyone have time for a review? Thanks!
Attachment #8693176 - Flags: review?(francisco)
Attachment #8693176 - Flags: review?(ferjmoreno)
Comment on attachment 8693176 [details] [review]
[gaia] KevinGrandon:bug_1147860_contacts_search_test_intermittent > mozilla-b2g:master

Thanks for the patch Kevin, r=me, I only left a tiny comment in gh.
Attachment #8693176 - Flags: review?(francisco) → review+
Comment on attachment 8693176 [details] [review]
[gaia] KevinGrandon:bug_1147860_contacts_search_test_intermittent > mozilla-b2g:master

Thanks for the review! Will fix the github comment.
Attachment #8693176 - Flags: review?(ferjmoreno)
Assignee: nobody → kevin+bugzilla
In master: https://github.com/mozilla-b2g/gaia/commit/a0b3b4bafc8bb7c67c47e9b2fafdeaa15f855e67
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: needinfo?(ferjmoreno)
Resolution: --- → FIXED
Depends on: 1234503
Reverting my fix as it caused functional breakage with the phone in bug 1234503 and was only meant to address an intermittent test.

I'd probably just recommend disabling this test for the time being, or doing a more simple guard in the test as originally suggested.

Backout: https://github.com/mozilla-b2g/gaia/commit/bf44b3161e9a62f78f0f8aca49a43bc66e69f680
Assignee: kevin+bugzilla → nobody
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Closing all intermittent test failures for Firefox OS (since we're not focusing on it anymore).

Please reopen if my search included your bug by mistake.
Firefox OS is not being worked on
Status: REOPENED → RESOLVED
Closed: 7 years ago5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.