1147909 - Update in-tree libpng to version 1.6.17

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Glenn Randers-Pehrson]

Libpng-1.6.17 has been released. We should upgrade the embedded libpng, but it's not urgent.

Comment 1

[Glenn Randers-Pehrson]

Attachment: v00-1147909-update-libpng-to-1_6_17

Comment 2

[Glenn Randers-Pehrson]

Attachment: Part01-v01-1147909-update-libpng-to-1_6_17-libpng

Comment 3

[Glenn Randers-Pehrson]

Attachment: Part02-v00-1147909-update-libpng-to-1_6_17-nsPNGDecoder

Comment 4

[Glenn Randers-Pehrson]

Attachment: Part03-v00-1147909-update-libpng-to-1_6_17-configure

Separate parts for updates to media/libpng, configure.in, and image/decoders/nsPNGDecoder.cpp

Comment 5

[Glenn Randers-Pehrson]

Need a "try" run (one run that applies all three parts)

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=011c08017872

Comment 7

[Glenn Randers-Pehrson]

The xpcshell apng tests failed.  This was essentially the same thing that happened in bug #1132081 comment#6; the zlib compression wasn't exactly the same.  This time it was because I'd removed a useless CMF-byte optimization.

Comment 8

[Glenn Randers-Pehrson]

Attachment: Part01-v02-1147909-update-libpng-to-1_6_17-libpng

Restored OPTIMIZE_CMF (increases footprint of libpng by about 1600 bytes).  I'll remove it again in bug #1137016

Comment 9

[Glenn Randers-Pehrson]

Need try run (all 3 parts)

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=54457e328d01

Comment 11

[Glenn Randers-Pehrson]

Comment on attachment 8585064 [details] [diff] [review]
Part02-v00-1147909-update-libpng-to-1_6_17-nsPNGDecoder

Try is all green.  r?

Comment 12

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8585882 [details] [diff] [review]
Part01-v02-1147909-update-libpng-to-1_6_17-libpng

Review of attachment 8585882 [details] [diff] [review]:
-----------------------------------------------------------------

FWIW, It would be nicer to read these diffs if you got rid of the "Last changed in libpng..." headers. That information is easily obtained with git log [filename]

Comment 13

[Glenn Randers-Pehrson]

checkin-needed (all three parts).  The "last changed" stuff is for the benefit of the 99.9 percent of our users who download tarballs (about 20000 downloads from SF versus 21 visitors to github over the past two weeks).

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fd7825c13623
https://hg.mozilla.org/integration/mozilla-inbound/rev/4681086315ff
https://hg.mozilla.org/integration/mozilla-inbound/rev/3beaa53b301d

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fd7825c13623
https://hg.mozilla.org/mozilla-central/rev/4681086315ff
https://hg.mozilla.org/mozilla-central/rev/3beaa53b301d