Closed Bug 1147951 Opened 10 years ago Closed 10 years ago

Remove uses of nsIProgrammingLanguage::JAVASCRIPT2 from Console.cpp

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

References

Details

Attachments

(3 files)

These are the only references to this, so I'm sure we can remove it safely.
Attachment #8584757 - Flags: review?(amarchesini) → review+
Attachment #8584758 - Flags: review?(amarchesini) → review+
Comment on attachment 8584759 [details] [diff] [review] part 3 - Remove unnecessary includes of nsIProgrammingLanguage. Review of attachment 8584759 [details] [diff] [review]: ----------------------------------------------------------------- lgtm ::: dom/bindings/Exceptions.cpp @@ +8,5 @@ > #include "js/GCAPI.h" > #include "js/TypeDecls.h" > #include "jsapi.h" > #include "jsprf.h" > +#include "nsIProgrammingLanguage.h" move this to line 17 after mozilla/dom/ScriptSettings.h. Just for alphabetic ordering ::: js/xpconnect/src/XPCJSID.cpp @@ +6,5 @@ > > /* An xpcom implementation of the JavaScript nsIID and nsCID objects. */ > > #include "xpcprivate.h" > +#include "nsIProgrammingLanguage.h" after line 14 ? ::: js/xpconnect/src/XPCWrappedNative.cpp @@ +6,5 @@ > > /* Wrapper object for reflecting native xpcom objects into JavaScript. */ > > #include "xpcprivate.h" > +#include "nsIProgrammingLanguage.h" after line 11
Attachment #8584759 - Flags: review?(amarchesini) → review+
Thanks for the reviews. I made the changes you requested for part 3. I also added back a few #includes that we need, but then I immediately removed them in bug 1147572. remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/b6bf54402f99 remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/206cdad835c1 remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/e9b95bab1c13
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: