Closed Bug 1147960 Opened 7 years ago Closed 7 years ago

Remove share_overlay_background.9.png

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
normal

Tracking

(firefox40 fixed)

RESOLVED FIXED
Firefox 40
Tracking Status
firefox40 --- fixed

People

(Reporter: mcomella, Assigned: beberveiga, Mentored)

References

Details

(Whiteboard: [good first bug])

Attachments

(1 file)

We have an unused asset: mobile/android/base/resources/drawable-hdpi/share_overlay_background.9.png. Remove it!

To start, set up a build environment - you can see the instructions here: https://wiki.mozilla.org/Mobile/Fennec/Android

Then, you'll need to create a patch to upload - see
https://wiki.mozilla.org/Mobile/Fennec/Android#Creating_commits_and_submitting_patches

If you need any help, you can reply to this bug, or feel free to message me on IRC - my nick is "mcomella" and you can find me in #mobile. If you need IRC setup instructions, see https://wiki.mozilla.org/IRC

Thanks and happy coding! ^_^
Attachment #8586517 - Flags: review?(michael.l.comella)
Comment on attachment 8586517 [details] [diff] [review]
1147960-remove-share_overlay_background.9.png.patch

Review of attachment 8586517 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me!

I made a push to our try test servers (see above).

Once it goes green, feel free to add the checkin-needed keyword [1]. Let me know if you need help reading the results. Note that all patches that use "checkin-needed" must also have an associated green try run.

[1]: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Getting_the_patch_checked_into_the_tree
Attachment #8586517 - Flags: review?(michael.l.comella) → review+
Assignee: nobody → contact
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/f6ffdba55a62
Keywords: checkin-needed
Whiteboard: [good first bug] → [good first bug][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/f6ffdba55a62
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug][fixed-in-fx-team] → [good first bug]
Target Milestone: --- → Firefox 40
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.