1148025 - IPC Proxy for 'Component'

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Attachment: v1

This has couple of somewhat random methods. I started to convert also the atk parts, but
realized there is something I'm not familiar with and need feedback from tbsaunde.

So, the patch has ipc parts only using similar checks what atk backend uses
(IsDefunct etc).

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

and I forgot 'override' from the methods.

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

(In reply to Olli Pettay [:smaug] from comment #1)
> and I forgot 'override' from the methods.

Yeah I missed that in your other patches too.

Comment 3

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 8583972 [details] [diff] [review]
v1

Review of attachment 8583972 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM (apart from override stuff)

::: accessible/ipc/PDocAccessible.ipdl
@@ +190,5 @@
>    prio(high) sync AddItemToSelection(uint64_t aID, uint32_t aIndex) returns(bool aSuccess);
>    prio(high) sync RemoveItemFromSelection(uint64_t aID, uint32_t aIndex) returns(bool aSuccess);
>    prio(high) sync SelectAll(uint64_t aID) returns(bool aSuccess);
>    prio(high) sync UnselectAll(uint64_t aID) returns(bool aSuccess);
>    

Optional nit: could remove these 2 spaces while you're here.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

I think I removed those spaces in some other patch.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Attachment: v2 (+override)

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Attachment: v3

merging with other stuff, no code changes

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8833d0060bca

apparently I managed to use wrong r=foo

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8833d0060bca