Closed Bug 1148025 Opened 5 years ago Closed 5 years ago

IPC Proxy for 'Component'

Categories

(Core :: Disability Access APIs, defect)

36 Branch
x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: smaug, Assigned: smaug)

Details

Attachments

(2 files, 1 obsolete file)

Attached patch v1Splinter Review
This has couple of somewhat random methods. I started to convert also the atk parts, but
realized there is something I'm not familiar with and need feedback from tbsaunde.

So, the patch has ipc parts only using similar checks what atk backend uses
(IsDefunct etc).
Attachment #8583972 - Flags: review?(dbolter)
and I forgot 'override' from the methods.
(In reply to Olli Pettay [:smaug] from comment #1)
> and I forgot 'override' from the methods.

Yeah I missed that in your other patches too.
Comment on attachment 8583972 [details] [diff] [review]
v1

Review of attachment 8583972 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM (apart from override stuff)

::: accessible/ipc/PDocAccessible.ipdl
@@ +190,5 @@
>    prio(high) sync AddItemToSelection(uint64_t aID, uint32_t aIndex) returns(bool aSuccess);
>    prio(high) sync RemoveItemFromSelection(uint64_t aID, uint32_t aIndex) returns(bool aSuccess);
>    prio(high) sync SelectAll(uint64_t aID) returns(bool aSuccess);
>    prio(high) sync UnselectAll(uint64_t aID) returns(bool aSuccess);
>    

Optional nit: could remove these 2 spaces while you're here.
Attachment #8583972 - Flags: review?(dbolter) → review+
I think I removed those spaces in some other patch.
Attached patch v2 (+override) (obsolete) — Splinter Review
Assignee: nobody → bugs
Attached patch v3Splinter Review
merging with other stuff, no code changes
Attachment #8584057 - Attachment is obsolete: true
https://hg.mozilla.org/integration/mozilla-inbound/rev/8833d0060bca

apparently I managed to use wrong r=foo
https://hg.mozilla.org/mozilla-central/rev/8833d0060bca
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.