1148068 - Indicate in tooltip that a run has been retriggered

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect, P3)

Description

[William Lachance (:wlach)]

If two datapoints are stacked on top of each other, it typically means that one is a retrigger of a talos run against the same revision. Let's point this out in the tooltip. Maybe also give it a retrigger number, for the case that there is more than one retrigger.

Comment 1

[MikeLing]

Hi Will,

I'm interesting in this bug, could you assign it to me? Thank you :)

Comment 2

[William Lachance (:wlach)]

Go for it. The trick in this bug will be finding datapoints that are retriggers of each other (== have the same result set id) in the performance data, then updating the UI to reflect that.

Comment 3

[MikeLing]

Attachment: PR for bug 1148068

Maybe there are some indented problems, I just use 4 indented in here for now and waiting feedback on github from Will.

Thank you :)

Comment 4

[Jonathan French (:jfrench)]

I did a quick pass in the PR, maybe some comments were useful. Feel free Mike to refer to this nice style guide on indentation, it shows some varied examples for wrapping and indentation. But you can also look to styles in the treeherder repo itself, there's often ones there.
http://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml > Code Formatting

Comment 5

[William Lachance (:wlach)]

Comment on attachment 8630845 [details] [review]
PR for bug 1148068

Looks good, just one thing I'd like changed. r-'ing just as a reminder to make that change and ask for review again!

Comment 6

[MikeLing]

Comment on attachment 8630845 [details] [review]
PR for bug 1148068

Done~ :)

Comment 7

[William Lachance (:wlach)]

Comment on attachment 8630845 [details] [review]
PR for bug 1148068

So on closer inspection, this wasn't quite what I had in mind originally (originally I thought we would number each retrigger datapoint indicating its sequence -- i.e. retrigger 1, 3, 4...), however on further thought I think just providing the raw number of retriggers in the tooltip may be good enough.

I think I'll push this for now. We can always push an update later.

Comment 8

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/80165b3c3b3403779369d0d32436eeeb3297b499
Bug 1148068 - Indicate in tooltip that a run has been retriggered