1148075 - dynamically add commands per-component

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[James Long (:jlongster)]

This is prep work for modularizing the frontend a bit. I want to reduce globals and right now the <command> elements add an event handler as a string in the DOM, which requires global access. Let's allow each component to dynamically add commands.

Comment 1

[James Long (:jlongster)]

Attachment: 1148075.patch

Can you take a look especially how I added the utils file to jar.mn? I have no experience with that. This worked though.

Comment 2

[Eddy Bruel [:ejpbruel]]

Hi James, I don't think I'm the best person to review this patch. I have limited experience with XUL, and I have no experience with jar.mn either. I think Victor would be a good candidate to take a look at this.

Victor, could you do me a favor and take a look at this patch for me?

Comment 3

[Victor Porof [:vporof][:vp]]

Comment on attachment 8584043 [details] [diff] [review]
1148075.patch

Review of attachment 8584043 [details] [diff] [review]:
-----------------------------------------------------------------

looks good

::: browser/devtools/debugger/utils.js
@@ +1,1 @@
> +

License boilerplate.

use strict.

@@ +14,5 @@
> +    Object.keys(commands).forEach(name => {
> +      let node = document.createElement('command');
> +      node.id = name;
> +      // XXX bug 371900: the command element must have an oncommand
> +      // attribute as a string set by `setAttribute` for keys to use it

ugh

Comment 4

[James Long (:jlongster)]

Attachment: 1148075.patch

rebased and comments addressed

Comment 5

[James Long (:jlongster)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c1d0bbddc890

Comment 6

[James Long (:jlongster)]

That intermittent is a known failure, and not related to this patch.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/2c7a6e149631

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2c7a6e149631