1148078 - Replace "Logical" w/ "FlexRelative" in flexbox functions/comments about [main-axis,cross-axis] positions & sizes

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Daniel Holbert [:dholbert]]

Before switching flexbox layout to logical coordinates in bug 1079155, we should get rid of misleading uses of the term "Logical" in nsFlexContainerFrame (which predate the logical-coordinates work).

I used "logical position/size" to refer to "main-axis/cross-axis position/size". For now, I'm going to switch to call these "flex-relative" instead of "logical".

(We may come up with a better term down the line; ideally, we should use something that applies to flex & grid. For now, "FlexRelative" is pretty clear, though, and we can do search-and-replace later if we think of something better.)

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix v1

Comment 2

[Daniel Holbert [:dholbert]]

I'm also changing some usages of position/posn/pos in the tweaked code to "coord" instead. (so e.g. "PhysicalPosFromLogicalPos" is now known as "PhysicalCoordFromFlexRelativeCoord").

I'm making this change since "position" is ambiguous about whether it's 1- or 2-dimensional value. "Coord" is a bit less ambiguous.

(Elsewhere in this file, I still have e.g. FlexItem::GetMainPosition/GetCrossPosition, but I think that's less ambiguous.)

Comment 3

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/638492d777fc

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/638492d777fc