Replace "Logical" w/ "FlexRelative" in flexbox functions/comments about [main-axis,cross-axis] positions & sizes

RESOLVED FIXED in Firefox 39

Status

()

Core
Layout
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

(Blocks: 1 bug)

Trunk
mozilla39
x86_64
Linux
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox39 fixed)

Details

Attachments

(1 attachment)

Before switching flexbox layout to logical coordinates in bug 1079155, we should get rid of misleading uses of the term "Logical" in nsFlexContainerFrame (which predate the logical-coordinates work).

I used "logical position/size" to refer to "main-axis/cross-axis position/size". For now, I'm going to switch to call these "flex-relative" instead of "logical".

(We may come up with a better term down the line; ideally, we should use something that applies to flex & grid. For now, "FlexRelative" is pretty clear, though, and we can do search-and-replace later if we think of something better.)
I'm also changing some usages of position/posn/pos in the tweaked code to "coord" instead. (so e.g. "PhysicalPosFromLogicalPos" is now known as "PhysicalCoordFromFlexRelativeCoord").

I'm making this change since "position" is ambiguous about whether it's 1- or 2-dimensional value. "Coord" is a bit less ambiguous.

(Elsewhere in this file, I still have e.g. FlexItem::GetMainPosition/GetCrossPosition, but I think that's less ambiguous.)

Updated

3 years ago
Attachment #8584058 - Flags: review?(mats) → review+
https://hg.mozilla.org/mozilla-central/rev/638492d777fc
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.