Closed Bug 1148123 Opened 10 years ago Closed 10 years ago

[gaia-header] Update gaia-icons dependency to resolve Bug 1148073

Categories

(Firefox OS Graveyard :: Gaia::Components, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Components
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: justindarc, Assigned: justindarc)

References

Details

Attachments

(1 file)

pull-request (master)
54 bytes, text/x-github-pull-request
drs
: review+
Details | Review
Currently, gaia-header cannot be used in an add-on that may be injected before documentElement exists. The gaia-icons dependency needs updated to v0.7.11.
Attached file pull-request (master) —
Assignee: nobody → jdarcangelo
Attachment #8584102 - Flags: review?(drs)
Attachment #8584102 - Flags: feedback?(wilsonpage)
Comment on attachment 8584102 [details] [review] pull-request (master) Looks good. Glad you're fixing the inconsistency in the version between 'package.json' and 'bower.json'.
Attachment #8584102 - Flags: review?(drs) → review+
Landed on master: https://github.com/gaia-components/gaia-header/commit/7ae28f9e847c78a6418b60bc168fc11754b2ebde
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Attachment #8584102 - Flags: feedback?(wilsonpage)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: