Closed Bug 1148139 Opened 5 years ago Closed 5 years ago

[Customizer] Inline stylesheets in JavaScript

Categories

(Firefox OS Graveyard :: Gaia, defect, P1)

x86
macOS
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: justindarc, Assigned: justindarc)

References

Details

(Whiteboard: [spark])

Attachments

(1 file)

Currently, stylesheets are unable to be injected into addons asynchronously. To work around this issue, we can inline the CSS in JavaScript for the Customizer.
Assignee: nobody → jdarcangelo
Priority: -- → P1
Whiteboard: [lightsaber]
Attached file pull-request (master)
Attachment #8584169 - Flags: review?(drs)
Comment on attachment 8584169 [details] [review]
pull-request (master)

See my comments on the PR. Might be fine, but let's talk about it first.
Attachment #8584169 - Flags: review?(drs) → review-
Comment on attachment 8584169 [details] [review]
pull-request (master)

I addressed your comments in the PR where possible and commented on some others (we can't comment out something in the .webapp manifest afaik). Let me know if there's anything else you want to discuss further. Thanks!
Attachment #8584169 - Flags: review- → review?(drs)
Comment on attachment 8584169 [details] [review]
pull-request (master)

Looks good. I left one last comment on the PR.
Attachment #8584169 - Flags: review?(drs) → review+
Landed on master:

https://github.com/fxos/customizer/commit/20b72991b51cc634f4998ecd8921254538cfea61
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
See Also: → 1148218
Whiteboard: [lightsaber] → [ignite]
Whiteboard: [ignite] → [spark]
You need to log in before you can comment on or make changes to this bug.