Closed
Bug 1148152
Opened 9 years ago
Closed 9 years ago
Intermittent conversion_banner_test.js | Message Type Conversion Banner Message Type Conversion Banner for new threads MMS to email conversion and reminders
Categories
(Firefox OS Graveyard :: Gaia::SMS, defect)
Tracking
(b2g-v2.2 affected, b2g-master fixed)
RESOLVED
FIXED
2.2 S11 (1may)
People
(Reporter: KWierso, Assigned: azasypkin)
Details
(Keywords: intermittent-failure, Whiteboard: [sms-sprint-2.2S11])
Attachments
(1 file)
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment 9•9 years ago
|
||
Assignee | ||
Comment 10•9 years ago
|
||
The issue here is that in suite "setup" function we try to create two threads manually (create and send new message) and fail to create the second one - tap on send button doesn't work for some unknown to me reason. In attached PR I replaced manual creation steps with predefined workload mechanism introduced in patch for bug 1043903, so this should fix intermittent failures here, but I still want to understand why marionette doesn't process send button tap correctly.
Flags: needinfo?(azasypkin)
QA Contact: azasypkin
Hardware: x86_64 → ARM
Updated•9 years ago
|
Assignee: nobody → azasypkin
QA Contact: azasypkin
Comment 11•9 years ago
|
||
I'd like to see this land ASAP. It will enable me to land bug 1141792. I can't right now because this test is too flacky.
Assignee | ||
Comment 12•9 years ago
|
||
Comment on attachment 8596548 [details] [review] [gaia] azasypkin:bug-1148152-conversion-banner-test > mozilla-b2g:master Hey Julien, I didn't have time to investigate the root cause here yet, but how do you feel about landing something like this in the meantime? It doesn't change main test idea. Thanks!
Attachment #8596548 -
Flags: review?(felash)
Comment 13•9 years ago
|
||
Comment on attachment 8596548 [details] [review] [gaia] azasypkin:bug-1148152-conversion-banner-test > mozilla-b2g:master r=me let's land this I don't reproduce on master, but with this patch it feels cleaner so if this fixes the issue as well then let's go. Still it's not reassuring that I couldn't reproduce at all while you reproduce at first try. Maybe we have an issue somewhere that will come back and bite us. Although the new architecture should change lots of things here.
Attachment #8596548 -
Flags: review?(felash) → review+
Assignee | ||
Comment 14•9 years ago
|
||
Thanks for review! I'll try to keep eye on the issue.
Status: NEW → ASSIGNED
Keywords: checkin-needed
Updated•9 years ago
|
Keywords: checkin-needed
Comment 15•9 years ago
|
||
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/44ec1d71fc6b9aebcb8ea712ac2ec09a93d21099
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment 18•9 years ago
|
||
v2.2: https://github.com/mozilla-b2g/gaia/commit/8612599f1737b2d8d204827c3bffbb349d64c6fe
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment 25•9 years ago
|
||
v2.2: https://github.com/mozilla-b2g/gaia/commit/558a90d086151e12d51cecea2a1e9b3507c4b493
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Updated•9 years ago
|
Whiteboard: [sms-sprint-2.2S11]
You need to log in
before you can comment on or make changes to this bug.
Description
•