Closed Bug 1148152 Opened 5 years ago Closed 5 years ago
_banner _test .js | Message Type Conversion Banner Message Type Conversion Banner for new threads MMS to email conversion and reminders
46 bytes, text/x-github-pull-request
|Details | Review|
Will take a look what is going on here.
The issue here is that in suite "setup" function we try to create two threads manually (create and send new message) and fail to create the second one - tap on send button doesn't work for some unknown to me reason. In attached PR I replaced manual creation steps with predefined workload mechanism introduced in patch for bug 1043903, so this should fix intermittent failures here, but I still want to understand why marionette doesn't process send button tap correctly.
QA Contact: azasypkin
Hardware: x86_64 → ARM
I'd like to see this land ASAP. It will enable me to land bug 1141792. I can't right now because this test is too flacky.
Comment on attachment 8596548 [details] [review] [gaia] azasypkin:bug-1148152-conversion-banner-test > mozilla-b2g:master Hey Julien, I didn't have time to investigate the root cause here yet, but how do you feel about landing something like this in the meantime? It doesn't change main test idea. Thanks!
Attachment #8596548 - Flags: review?(felash)
Comment on attachment 8596548 [details] [review] [gaia] azasypkin:bug-1148152-conversion-banner-test > mozilla-b2g:master r=me let's land this I don't reproduce on master, but with this patch it feels cleaner so if this fixes the issue as well then let's go. Still it's not reassuring that I couldn't reproduce at all while you reproduce at first try. Maybe we have an issue somewhere that will come back and bite us. Although the new architecture should change lots of things here.
Attachment #8596548 - Flags: review?(felash) → review+
Thanks for review! I'll try to keep eye on the issue.
Status: NEW → ASSIGNED
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/44ec1d71fc6b9aebcb8ea712ac2ec09a93d21099
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.