Closed
Bug 1148157
Opened 9 years ago
Closed 9 years ago
implement platform selector
Categories
(Marketplace Graveyard :: Consumer Pages, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
2015-04-14
People
(Reporter: ddurst, Assigned: kngo)
References
Details
Update the platform selector to match the new design (desktop and mobile).
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → kngo
Assignee | ||
Comment 1•9 years ago
|
||
https://github.com/mozilla/fireplace/pull/1106 The platform selector will only show up when you enable the Nav through the Debug page, and on pages where device filtering is enabled (Popular, New, Search, etc).
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2015-04-07
Comment 2•9 years ago
|
||
On devices (FF OS 2.0 and Android 4.2.1), I observed the following: 1. There is no arrow for the drop-down list 2. The platform options are confusing when read with default "Show me apps" text 3. There are only two options (All Apps, and Apps for my device); that, I recall, was changed. Please see the screenshot http://screencast.com/t/xOdo8aNY Also, when the MP-dev app(or FF40 browser) is first opened, the platform selector states: "Show me apps for undefined" - http://screencast.com/t/7DFbwJsXMH
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 3•9 years ago
|
||
1. I've fixed the arrow. 2. We will have to ignore that for now and trust that when we actually turn on the Nav's settings flag, that it will display the proper text (e.g, "All Platforms" rather than "All Apps"). This is due to the way we render the Nav through the Debug page and Marketplace having already initialized with the current text. 3. That did change as a regression. It was just fixed so expect an all-apps option and an apps-for-my-device option. 4. For the "undefined", I pushed a fix to hopefully address it, although I could not reproduce it.
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
Updated•9 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 4•9 years ago
|
||
The language in the platform filter will change when we launch MOW. So we'd like to change it now before we launch the platform filter. The new language is this: Show everything for [option] The new language works now, and it will work later for MOW. Thanks.
Assignee | ||
Comment 5•9 years ago
|
||
https://github.com/mozilla/fireplace/commit/1c6e6a8f5e556e4ebb73119e37f80d30fdaefdaf
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
Target Milestone: 2015-04-07 → 2015-04-14
Updated•9 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•