114817 - Using single quote chars in product names breaks bugzilla.

Status: RESOLVED DUPLICATE of bug 42810

(Bugzilla :: Administration, task)

Description

[Ryan C. Gordon]

It appears that Bugzilla doesn't escape the product names when building the
data/versioncache file (function GenerateVersionTable() in globals.pl). Fix
attached as unified diff for version 2.14. There may be other things in
globals.pl that need to be wrapped in PerlQuote() calls, too, but this was the
first one that hit me.

--ryan. ([e-mail])

Download url (if this textarea munges the diff):
https://bugzilla.icculus.org/patches/bugzilla-2.14-quotes-in-product-name-RYAN-1.diff


--- /root/bugzilla-2.14/globals.pl	Wed Aug 29 15:52:13 2001
+++ globals.pl	Wed Dec 12 03:21:27 2001
@@ -409,7 +409,7 @@
         $result = "";
         foreach my $k (sort { uc($a) cmp uc($b)} eval("keys $name")) {
             $result .= GenerateCode("\$" . substr($name, 1) .
-                                    "{'" . $k . "'}");
+                                    "{" . PerlQuote($k) . "}");
         }
         return $result;
     } else {

Comment 1

[Ryan C. Gordon]

Attachment: Patch to fix quoting of product name string.

(or, I could just attach it the right way. Whoops. :)  )

--ryan. ([e-mail])

Comment 2

[Dave Miller [:justdave]]

already fixed.

*** This bug has been marked as a duplicate of 42810 ***