1148186 - Show more details in flamegraph when hovering over a frame

Status: RESOLVED MOVED

(DevTools :: Performance Tools (Profiler/Timeline), defect, P3)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

I should be able to just hover over a frame in the flame graph and it should show that frame's

* function name and location

* self time (for this specific frame in the flame graph)

* total time (for this specific frame in the flame graph)

* aggregate self time (for all instances of this frame in the flame graph)

* aggregate total time (for all instances of this frame in the flame graph)

* aggregate percent of samples where this frame was the leaf

Comment 3

[Paul Rouget [:paul]]

To me, this is the biggest usability problem I have with the flamegraph.

Comment 4

[Jordan Santell [:jsantell] [@jsantell]]

Started working on this and we do not have any of the cost times associated with this data, as the flame graph takes the original profile, and does not use the same format as the calltree does after it calculates the costs.

We should share this information somehow, and there's a lot of going on with the calltree format right now.

Comment 5

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1148186.patch

proof of concept http://i.imgur.com/IdVpLEN.gif

Comment 6

[Jordan Santell [:jsantell] [@jsantell]]

This requires more data massaging and overhead to get the info we need so will take longer to do this than expected. Filing bug 1160206 as an easier replacement for now. If this is a P1 for June 2nd, we'll need to chop some other things.

Comment 7

[Victor Porof [:vporof][:vp]]

Triaging. Filter on ADRENOCORTICOTROPIC (yes).

Comment 8

[Julien Wajsberg [:julienw]]

I moved this to https://github.com/firefox-devtools/profiler/issues/3983