Closed Bug 1148305 Opened 7 years ago Closed 7 years ago

[Metrics] Remove duplicated entries in the App Usage Ping

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(b2g-v2.2 fixed, b2g-master fixed)

RESOLVED FIXED
2.2 S9 (3apr)
Tracking Status
b2g-v2.2 --- fixed
b2g-master --- fixed

People

(Reporter: shinglyu, Assigned: thills)

References

Details

Attachments

(2 files)

(This is a followup bug for bug 1137067)

As in bug 1137067, we need to remove the duplicated appUpdateChannel, appBuildID and appVersion fields in the app usage ping to reduce traffic.
Seems pretty important to me.
blocking-b2g: --- → 2.2?
Assignee: nobody → thills
FWIW, I think the impact of this duplication in the FTU ping is a lot smaller -- it will only be submitted once for the lifetime of a device.
Attached file patch
Attachment #8586293 - Flags: review?(marshall)
Status: NEW → ASSIGNED
Comment on attachment 8586293 [details] [review]
patch

Looks good :)
Attachment #8586293 - Flags: review?(marshall) → review+
Comment on attachment 8586293 [details] [review]
patch

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Desire to conserve data usage for end user on app usage ping.
[User impact] if declined:  User will consume little more data to send app usage pings.
[Testing completed]: yes
[Risk to taking this patch] (and alternatives if risky): low/med.
[String changes made]:none.
Attachment #8586293 - Flags: approval-gaia-v2.2?(bbajaj)
Michael or Hema can you help triage this. Not sure if it requires uplift for 2.2?
Flags: needinfo?(mtreese)
Flags: needinfo?(hkoka)
Diff seems to remove redundant fields and thereby conserve a small amount of data usage and I would not block based on comment 2. 

However, patch risk is low and has been tested based on comment 7, so we could take it with approval. Bhavana, please check the overall status of release and see if we can take these changes into 2.2
Flags: needinfo?(hkoka)
Comment on attachment 8586293 [details] [review]
patch

If we have any fallouts we can backout Uplifting it as this is a part new feature in 2.2
Attachment #8586293 - Flags: approval-gaia-v2.2?(bbajaj) → approval-gaia-v2.2+
blocking-b2g: 2.2? → ---
Verified on 2.2 
{
    "info": {
        "appBuildID": "20150407002501",
        "appName": "FirefoxOS",
        "appUpdateChannel": "default",
        "appVersion": "37.0",
        "apps": {
            "app://verticalhome.gaiamobile.org/manifest.webapp": {
                "20150408": {
                    "activities": {},
                    "installs": 0,
                    "invocations": 2,
                    "uninstalls": 0,
                    "usageTime": 56
                }
            },
            "https://marketplace.firefox.com/app/bb680dfa-2ac1-45e1-b71b-3db4520c8ca8/manifest.webapp": {
                "20150408": {
                    "activities": {},
                    "installs": 1,
                    "invocations": 1,
                    "uninstalls": 0,
                    "usageTime": 7
                }
            },
            "https://marketplace.firefox.com/packaged.webapp": {
                "20150408": {
                    "activities": {},
                    "installs": 0,
                    "invocations": 1,
                    "uninstalls": 0,
                    "usageTime": 13
                }
            }
        },
        "deviceID": "46a155ac-02c9-4203-ab32-3a731a7e6499",
        "deviceinfo": {
            "developer.menu.enabled": true,
            "deviceinfo.hardware": "hammerhead",
            "deviceinfo.os": "2.2.0.0-prerelease",
            "deviceinfo.product_model": "AOSP on HammerHead",
            "deviceinfo.software": "Boot2Gecko 2.2.0.0-prerelease"
        },
        "locale": "zh-TW",
        "reason": "appusage",
        "screen": {
            "devicePixelRatio": 3,
            "height": 640,
            "width": 360
        },
        "searches": {},
        "simInfo": {
            "icc": null,
            "network": null
        },
        "start": 1428476257004,
        "stop": 1428476338673
    },
    "ver": 1
}

Build:
  Gaia-Rev        ea735c21bfb0d78333213ff0376fce1eac89ead6
  Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/245f37f44017
  Build-ID        20150407002501
  Version         37.0
  Device-Name     hammerhead
  FW-Release      5.0
  FW-Incremental  eng.cltbld.20150407.040951
  FW-Date         Tue Apr  7 04:10:07 EDT 2015
  Bootloader      HHZ12d
Flags: needinfo?(mtreese)
You need to log in before you can comment on or make changes to this bug.