1148309 - No SimLockScreen displayed after toggling Airplane Mode ON/OFF when all slots are presents at SimSlotManager.init() with Bug 1114935 is landed.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Bevis Tseng[:bevis][:btseng](Exited)]

To adopt the change of bug 1114935,
In bug 1140314, we ensured that 'simslotready' is published if all cards are ready in SIMSlotManager.init() and bail out earlier without adding EventListener to 'iccdetected'.

However, it will cause the regression of NO SimLockScreen displayed after toggling airplane mode ON/OFF if bug 1114935 is landed.

The reason is that, without 'iccdetected', SIMSlot.update() will never be invoked anymore to replace the iccObj to the new one created from MozIccManager.

Hence, file this bug to address this problem to ensure that "iccdetected" will always be listened.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] bevis-tseng:Bug_1148309 > mozilla-b2g:master. r=alive

Comment 2

[Bevis Tseng[:bevis][:btseng](Exited)]

Comment on attachment 8584332 [details] [review]
[gaia] bevis-tseng:Bug_1148309 > mozilla-b2g:master. r=alive

This is to ensure 'iccdetected' will always be listened by SimSlotManager even all cards are detected at init() to allow SimSlot to be updated with the new IccObject from MozIccManager when airplane mode is toggled ON/OFF.

Hi Alive,

May I have your review for this fix?
Test case is also modified accordingly.

Thanks!

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8584332 [details] [review]
[gaia] bevis-tseng:Bug_1148309 > mozilla-b2g:master. r=alive

r=me

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

BTW, it's better if you could comment the reason in the code base in order to prevent someone else remove the event listener again.

Comment 5

[Bevis Tseng[:bevis][:btseng](Exited)]

(In reply to Alive Kuo [:alive][NEEDINFO!] from comment #4)
> BTW, it's better if you could comment the reason in the code base in order
> to prevent someone else remove the event listener again.

Thanks for reminding, I'll update the PR with more explanation.

Comment 6

[Bevis Tseng[:bevis][:btseng](Exited)]

try-server is green:
https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=21ce3acc7bcaef34ec17e2000fc251c7decb2dc1

Comment 7

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/3e00b3f216007774ddccad80d9baef6ef34243b6