1148347 - [Flame][Gallery]Plug and unplug USB line, select a photo and enter edit view again, two photos are overlaped.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Gallery, defect)

Description

[Shine(Leave from Mozilla)]

Attachment: logcat_2050.txt

[1.Description]:
[Flame][V2.1&v2.2&v3.0][Gallery]On photo edit view, plug in USB line to connecte device to PC, Unplug USB line, select a photo and enter edit view again, the two photos are overlaped.
See attachment: VIDEO1215_Compress.MP4 & logcat_2050.txt
Found at: 20:50

[2.Testing Steps]: 
1. Launch Settings app and turn on "USB Storage".
2. Press Home button and launch Gallery app.
3. Select a photo and tap edit icon.
4. Plug in USB line to connecte device to PC.
5. Unplug USB line.
6. Select a photo and enter edit view again.
7. Rotate device to landscape mode.


[3.Expected Result]: 
6&7. It should only display the photo you just selected.

[4.Actual Result]: 
6&7. The two photos are overlaped.

[5.Reproduction build]: 
Device: 
Flame 2.0 (Unaffected)
Build ID               20150326160207
Gaia Revision          896803174633fc6acd3fd105f81c349b8e9b9633
Gaia Date              2015-03-10 06:32:26
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/adb9d7679526
Gecko Version          32.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150326.192953
Firmware Date          Thu Mar 26 19:30:02 EDT 2015
Bootloader             L1TC000118D0

Flame 2.1 (Affected)
Build ID               20150326001202
Gaia Revision          6f39e4e876152de1dcdcc0e7656197f22f105e4b
Gaia Date              2015-03-25 11:16:16
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/e00ae73d67a2
Gecko Version          34.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150326.035122
Firmware Date          Thu Mar 26 03:51:33 EDT 2015
Bootloader             L1TC000118D0

Flame 2.2 (Affected)
Build ID               20150326002504
Gaia Revision          e59ac067a1d22b7a72cbebc892ec652723f2a557
Gaia Date              2015-03-26 00:02:53
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/04b4b9d1faae
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150326.042521
Firmware Date          Thu Mar 26 04:25:30 EDT 2015
Bootloader             L1TC000118D0

Flame 3.0 (Affected)
Build ID               20150326160206
Gaia Revision          525c341254e08f07f90da57a4d1cd5971a3cc668
Gaia Date              2015-03-26 16:34:16
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/59554288b4eb
Gecko Version          39.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150326.193247
Firmware Date          Thu Mar 26 19:32:58 EDT 2015
Bootloader             L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
Free Test

[8.Note]:
This problem cannot be reproduced on Flame 2.0.

Comment 1

[Shine(Leave from Mozilla)]

Attachment: VIDEO1215_Compress.MP4

Comment 2

[No-Jun Park [:njpark]]

[Blocking Requested - why for this release]:

Still able to reproduce it on Flame device.Although this is not a common use case scenario, overlapping images look quite serious, and they might be unforeseen issues around it. nominating to block.

Comment 3

[Hema Koka [:hema]]

Users can plugin to charge as well while they are editing. It is really bad experience to see overlapped photos -- users may think that image got corrupted or something. Blocking

Comment 4

[Punam Dahiya [:pdahiya]]

Investigated and the issue is when the user is editing image and device is mounted for usb storage, photodb onunavailable event handler sets gallery view to thumbnail list view without revoking blob URLs and closing editor object which persist when user enter edit view again. I will submit patch to call exitEdit inside photodb onunavailable handler. Thanks!

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] punamdahiya:Bug1148347 > mozilla-b2g:master

Comment 6

[Punam Dahiya [:pdahiya]]

Comment on attachment 8643874 [details] [review]
[gaia] punamdahiya:Bug1148347 > mozilla-b2g:master

Hi David
Attaching patch that checks for editView inside photodb unavailable handler and calls exitEdit if the user is editing image before enabling usb storage. Please review. Thanks!

Comment 7

[David Flanagan [:djf]]

Comment on attachment 8643874 [details] [review]
[gaia] punamdahiya:Bug1148347 > mozilla-b2g:master

Thanks Punam. r+ if you fix the two minor nits I mentioned on github

Comment 8

[Punam Dahiya [:pdahiya]]

Thanks David for review. Updated patch with feedback and landed on master.

https://github.com/mozilla-b2g/gaia/commit/cc75cfbd198a06ce517bcaee384b61a204fe2fe1

Comment 9

[Annabelle]

Attachment: Verified_Flame_kk_v2.5.3gp

This bug has been verified as "Pass" on latest build of  Flame KK v2.5 by the STR in Comment 0.
Actual results: It only display the photo you just selected.

See attachment: Verified_Flame_kk_v2.5.3gp
Reproduce rate: 0/5

Device: Flame KK 2.5(Pass)
Build ID               20150827150209
Gaia Revision          d784c81961d82cbe9e111405468c590a8345856c
Gaia Date              2015-08-27 12:29:28
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/ca086f9ef8bca2d6cdfa79bfc4c854f56a59859e
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150827.190412
Firmware Date          Thu Aug 27 19:04:26 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0