Closed Bug 1148433 Opened 5 years ago Closed 5 years ago

Awesome screen should remember last used home panel

Categories

(Firefox for iOS :: General, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
Tracking Status
fennec + ---

People

(Reporter: st3fan, Assigned: bmunar)

References

Details

(Whiteboard: noteworthy)

Attachments

(1 file)

47 bytes, text/x-github-pull-request
bnicholson
: review+
Details | Review
The awesome screen should remember the last used home panel.

So that when you tap the location bar the second time, it shuold go immediately to the panel you came from.
This should probably be per tab based. On Android we use urls like about:home#reader to track the page you're on (for this tab).
tracking-fennec: ? → +
(In reply to Wesley Johnston (:wesj) from comment #1)
> This should probably be per tab based. On Android we use urls like
> about:home#reader to track the page you're on (for this tab).

We use about:home?panel=whatever on Android, although we use UUIDs for the built-in panel types:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/home/HomeConfig.java#1497

Looking through the code, I don't really see where we use this in the product... this might just be something that add-ons use:
https://github.com/leibovic/pocket-panel/blob/master/bootstrap.js#L44
Assignee: nobody → wjohnston
Assignee: wjohnston → bmunar
Status: NEW → ASSIGNED
Depends on: 1170769
Attached file Pull Request
Attachment #8614306 - Flags: review?(bnicholson)
Comment on attachment 8614306 [details] [review]
Pull Request

Using URL fragments is an issue right now due to bug 1170726, so this is a reasonable approach in the meantime. Added some comments in the PR.
Attachment #8614306 - Flags: review?(bnicholson) → feedback+
Attachment #8614306 - Flags: review?(bnicholson)
Comment on attachment 8614306 [details] [review]
Pull Request

Looks good to me with minor cleanup mentioned in the PR.
Attachment #8614306 - Flags: review?(bnicholson)
Attachment #8614306 - Flags: review+
Attachment #8614306 - Flags: feedback+
https://github.com/mozilla/firefox-ios/commit/4829d12f26bae94f8672a76ebff4e9266be45bad
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Depends on: 1171254
Whiteboard: noteworthy
You need to log in before you can comment on or make changes to this bug.