1148433 - Awesome screen should remember last used home panel

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

The awesome screen should remember the last used home panel.

So that when you tap the location bar the second time, it shuold go immediately to the panel you came from.

Comment 1

[Wesley Johnston (:wesj)]

This should probably be per tab based. On Android we use urls like about:home#reader to track the page you're on (for this tab).

Comment 2

[:Margaret Leibovic]

(In reply to Wesley Johnston (:wesj) from comment #1)
> This should probably be per tab based. On Android we use urls like
> about:home#reader to track the page you're on (for this tab).

We use about:home?panel=whatever on Android, although we use UUIDs for the built-in panel types:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/home/HomeConfig.java#1497

Looking through the code, I don't really see where we use this in the product... this might just be something that add-ons use:
https://github.com/leibovic/pocket-panel/blob/master/bootstrap.js#L44

Comment 3

[:Margaret Leibovic]

Aha: https://bugzilla.mozilla.org/show_bug.cgi?id=909618

Comment 4

[Bryan Munar (:bkmunar)]

Attachment: Pull Request

Comment 5

[Brian Nicholson (:bnicholson)]

Comment on attachment 8614306 [details] [review]
Pull Request

Using URL fragments is an issue right now due to bug 1170726, so this is a reasonable approach in the meantime. Added some comments in the PR.

Comment 6

[Brian Nicholson (:bnicholson)]

Comment on attachment 8614306 [details] [review]
Pull Request

Looks good to me with minor cleanup mentioned in the PR.

Comment 7

[Brian Nicholson (:bnicholson)]

https://github.com/mozilla/firefox-ios/commit/4829d12f26bae94f8672a76ebff4e9266be45bad