1148446 - Add checkbox to step 2 for side-loading

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P1)

Description

[Wil Clouser [:clouserw]]

Add a sub-checkbox, disabled (or hidden) and unchecked by default saying "This add-on will be side-loaded via application installers."

Add a help bubble saying "Add-ons that are side-loaded will be code reviewed by Mozilla before they are signed and are held to a higher quality standard."


From: https://docs.google.com/a/mozilla.com/drawings/d/1DOJpCF7ytkbi57S6-YsWD17778WkrQI9Vy2ot3nJHCk/edit

Comment 1

[Mathieu Agopian [:magopian]]

Just to complete the information, taken from the same doc:

1/ the sub-checkbox will only be displayed/enabled if the "Yes, distribute my add-on on this site." checkbox is NOT selected (so it's an unlisted addon)
2/ not selecting this sub-checkbox (not making it side-loadable) will put the addon in the unlisted preliminary review queue (STATUS_UNREVIEWED)
3/ selecting this sub-checkbox (making it side-loadable) will put the addon in the unlisted full review queue (STATUS_NOMINATED)

Comment 2

[Mathieu Agopian [:magopian]]

PR: https://github.com/mozilla/olympia/pull/499

Comment 3

[Mathieu Agopian [:magopian]]

Fixed in https://github.com/mozilla/olympia/commit/37b73302cbb3400e8cdd48a7454eabcdf8ce8bfb

Comment 4

[Madalin Cotetiu]

Verified as fixed in FF37(Win7) in addons-dev.allizom.org
- Side-loaded add-ons are put in unlisted full review queue.
- Unlisted and not side-loaded add-ons are put in unlisted preliminary review queue.

Postfix screencast: http://screencast.com/t/5sSuENFp