Closed
Bug 1148473
Opened 10 years ago
Closed 10 years ago
Lower BHR threshold
Categories
(Toolkit :: Telemetry, defect)
Tracking
()
RESOLVED
FIXED
mozilla40
| Tracking | Status | |
|---|---|---|
| firefox40 | --- | fixed |
People
(Reporter: rvitillo, Assigned: rvitillo)
Details
Attachments
(1 file)
|
1.20 KB,
patch
|
vladan
:
review+
|
Details | Diff | Splinter Review |
We want to lower the BHR threshold around 100ms to collect more fine-grained data.
| Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8584640 -
Flags: review?(vdjeric)
Comment 2•10 years ago
|
||
Comment on attachment 8584640 [details] [diff] [review]
1148473
Review of attachment 8584640 [details] [diff] [review]:
-----------------------------------------------------------------
r+ for the trivial patch. did you estimate how much bigger the payload will be?
Attachment #8584640 -
Flags: review?(vdjeric) → review+
Updated•10 years ago
|
Flags: needinfo?(rvitillo)
| Assignee | ||
Comment 3•10 years ago
|
||
We should have about 25% more hangs in a submission which our backend can easily handle.
Flags: needinfo?(rvitillo)
Comment 4•10 years ago
|
||
One thing to check in conjunction with this change: any scheduled analysis jobs looking at BHR data should have their "timeout" adjusted if needed - more data == more processing time.
| Assignee | ||
Comment 5•10 years ago
|
||
Mark, I don't own any scheduled jobs that use BHR data; could you please adjust the timeout of the jobs you mentioned? Not sure if there is anything out there beyond the one used to feed the BHR dashboard.
Flags: needinfo?(mreid)
Comment 6•10 years ago
|
||
If it's only that one BHR job, then it looks fine as-is. Its timeout is set far higher than the job typically takes. It would be a good idea to keep an eye on the BHR analysis logs after this lands.
Flags: needinfo?(mreid)
| Assignee | ||
Comment 7•10 years ago
|
||
I am not sure that we have just that one job as I can access only the ones I created. Could you please double check if there are others?
Comment 8•10 years ago
|
||
None of the other jobs sound like they have anything to do with BHR.
| Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 9•10 years ago
|
||
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Comment 10•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•