Closed Bug 1148479 Opened 5 years ago Closed 5 years ago

Unify string conversions in mozAccessible.mm

Categories

(Core :: Disability Access APIs, defect)

x86_64
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: MarcoZ, Assigned: MarcoZ)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

There are two instances in MozAccessible.mm where we don't use the CocoaUtils::ToNSString method for conversion. This patch simply cleans that up.
Attachment #8584652 - Flags: review?(surkov.alexander)
Comment on attachment 8584652 [details] [diff] [review]
Clean up string conversion calls

Review of attachment 8584652 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/mac/mozAccessible.mm
@@ +539,5 @@
>    NS_OBJC_BEGIN_TRY_ABORT_BLOCK_NIL;
>  
>    nsAutoString value;
>    mGeckoAccessible->Value(value);
> +  return nsCocoaUtils::ToNSString(value);

the only difference is we used to return nil, but ToNSString returns empty string, but since we use ToNSString for title and description then we should be good to do so for value and help so r=me
Attachment #8584652 - Flags: review?(surkov.alexander) → review+
https://hg.mozilla.org/mozilla-central/rev/76f46106d07e
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.