Unify string conversions in mozAccessible.mm

RESOLVED FIXED in Firefox 39

Status

()

Core
Disability Access APIs
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: MarcoZ, Assigned: MarcoZ)

Tracking

(Blocks: 2 bugs)

Trunk
mozilla39
x86_64
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox39 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Created attachment 8584652 [details] [diff] [review]
Clean up string conversion calls

There are two instances in MozAccessible.mm where we don't use the CocoaUtils::ToNSString method for conversion. This patch simply cleans that up.
Attachment #8584652 - Flags: review?(surkov.alexander)

Comment 1

3 years ago
Comment on attachment 8584652 [details] [diff] [review]
Clean up string conversion calls

Review of attachment 8584652 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/mac/mozAccessible.mm
@@ +539,5 @@
>    NS_OBJC_BEGIN_TRY_ABORT_BLOCK_NIL;
>  
>    nsAutoString value;
>    mGeckoAccessible->Value(value);
> +  return nsCocoaUtils::ToNSString(value);

the only difference is we used to return nil, but ToNSString returns empty string, but since we use ToNSString for title and description then we should be good to do so for value and help so r=me
Attachment #8584652 - Flags: review?(surkov.alexander) → review+

Updated

3 years ago
Blocks: 389800
(Assignee)

Comment 2

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/76f46106d07e
Assignee: nobody → mzehe
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/76f46106d07e
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.