1148533 - [Windows Management][SHB] - The long-press power button menu is cut off on the bottom when viewing it in Lockscreen Camera mode with Passcode Lock enabled

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Joshua Mitchell (Inactive)]

Description:
 Accessing the camera from the homescreen with SHB and Passcode lock enabled cause the bottom of the Long-press power menu to be cut-off.

Repro Steps:
1) Update a Flame to 20150327010205
2) Enable Passcode lock and SHB and lock the device
3) Unlock the device and slide the slider to the left to launch camera
4) Long press the power button

Actual:
Menu does not fully show / cut off on bottom

Expected:
Menu and options will fully display

Environmental Variables:
Device: Flame Master
Build ID: 20150327010205
Gaia: 249b8c08c1d57961ef6c905f3498fa62b032bf24
Gecko: e046475a75cb
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 39.0a1 (Master)
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0


Repro frequency: 10/10
See attached: screenshot

Comment 1

[Joshua Mitchell (Inactive)]

This issue also occurs in Flame KK 2.2 and 2.1 

Device: Flame 2.2 (KK - Nightly - Full Flash - 319mem)
Build ID: 20150327002500
Gaia: f9f62d7b69c9d46a28b5ca4f18993c90b5a2b26a
Gecko: 17079fdf6c6f
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 37.0 (Master)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0


Device: Flame 2.1 (KK - Nightly - Full Flash - 319mem)
Build ID: 20150325001202
Gaia: b8ae0df34362420fe4a9c90effa5247a1f5c844d
Gecko: 2a05cd42088b
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 34.0 (2.1)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

--------------------------------------------------------------------------------------------

This issue does NOT reproduce in 2.0

Actual Results: The long-press power button menu is NOT cut-off and instead fully displays

Device: Flame 2.0 (KK - Nightly - Full Flash - 319mem)
Build ID: 20150325000205
Gaia: 896803174633fc6acd3fd105f81c349b8e9b9633
Gecko: 543c2325d667
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 32.0 (2.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 2

[Joshua Mitchell (Inactive)]

Attachment: 2015-03-27-14-07-05.png

Comment 3

[Joshua Mitchell (Inactive)]

I uhhh.......   ya...

Comment 4

[Peter Bylenga [:PBylenga]]

NI on component owner for nomination decision, is a regression affecting 2.1.

Comment 5

[Brogan Zumwalt [Inactive]]

Added qawanted to check branches on v18D-1 base

Comment 6

[Brogan Zumwalt [Inactive]]

Issue DOES reproduce on Flame 3.0 with v18D-1 base

Power menu does not fully show / cut off on bottom when activated from lockscreen camera with SHB enabled

Device: Flame 3.0
Build ID: 20150327010205
Gaia: 249b8c08c1d57961ef6c905f3498fa62b032bf24
Gecko: e046475a75cb
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 39.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Comment 7

[Gerry Chang [:gchang]]

NI System FE owner for this.

Comment 8

[Hermes Cheng (inactive after July 27, 2015)]

Etienne, could you take a look?

Comment 9

[Gregor Wagner [:gwagner]]

SHB issue

Comment 10

[Etienne Segonzac (:etienne)]

I can reproduce, taking a look.

Comment 11

[GitHub Autolander Bot]

Attachment: [gaia] etiennesegonzac:bug-1148533 > mozilla-b2g:master

Comment 12

[Etienne Segonzac (:etienne)]

Comment on attachment 8585563 [details] [review]
[gaia] etiennesegonzac:bug-1148533 > mozilla-b2g:master

Even comes with a test :)

Comment 13

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8585563 [details] [review]
[gaia] etiennesegonzac:bug-1148533 > mozilla-b2g:master

Stealing the review as gmarty is on PTO.

Works like a charm, and thanks for the test!

Comment 14

[GitHub Autolander Bot]

https://github.com/mozilla-b2g/gaia/pull/29225

Autolander could not land the pull request due to not having collaborator rights. This is possibly due to a tree closure. Please check the tree status and request checkin again once the tree is open.

Comment 15

[Kevin Grandon :kgrandon]

Infra problems today, so landing manually: https://github.com/mozilla-b2g/gaia/commit/5e80e3d725b274b6977dc18c522f0ee6fbccfc5e

Comment 16

[Hermes Cheng (inactive after July 27, 2015)]

Please uplift to 2.2 since it is a 2.2 blocker. Thanks.

Comment 17

[Etienne Segonzac (:etienne)]

Comment on attachment 8585563 [details] [review]
[gaia] etiennesegonzac:bug-1148533 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): SHB
[User impact] if declined: the sleep menu is cut out
[Testing completed]: sleep menu in various state
[Risk to taking this patch] (and alternatives if risky): very low
[String changes made]: none

Comment 18

[Shally Li（leave from Mozilla）]

According to the STR of Comment 0,this bug has been successfully verified on latest Nightly Flame v3.0.

Actual results:After unlocking/sliding to the left to launch camera,the Cancel button and options will fully display.

See attachment: verified_v3.0.png.
Reproduce rate: 0/5

Device: Flame 3.0 build(Pass)
Build ID               20150402160202
Gaia Revision          62042ffcc8c6cca0f51ad23f5c2b979fc153b5a7
Gaia Date              2015-04-02 16:01:42
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/513265a4cbc2
Gecko Version          40.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150402.192125
Firmware Date          Thu Apr  2 19:21:37 EDT 2015
Bootloader             L1TC000118D0

Leaving keywords "verifyme" for Flame v2.2&2.1.

Comment 19

[Shally Li（leave from Mozilla）]

Attachment: verified_v3.0.png

Comment 20

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/e96db43ca8d684e3222cf788417b61a8a207ae94

Comment 21

[Shally Li（leave from Mozilla）]

According to the STR of Comment 0,this bug has been successfully verified on latest Nightly Flame v2.2.
(Rate: 0/5)

Actual results:After unlocking or sliding to the left to launch camera,the Cancel button will fully display.

Device: Flame 2.2 build(Pass)
Gaia Revision          a6351e1197d54f8624523c2db9ba1418f2aa046f
Gaia Date              2015-04-03 22:06:41
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/c3335a5d3063
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150406.040047
Firmware Date          Mon Apr  6 04:00:58 EDT 2015
Bootloader             L1TC000118D0

Comment 22

[Norry.L.F(Leave from Mozilla)]

Hi Josh,

This bug is regression, should we uplift patch to Flame 2.1? 
Thanks

Comment 23

[Josh Cheng [:josh]]

Hi Etienne,
Could you please help to raise 2.1 approval as this is regression issue?
Thanks!

Comment 24

[Etienne Segonzac (:etienne)]

(In reply to Josh Cheng [:josh] from comment #23)
> Hi Etienne,
> Could you please help to raise 2.1 approval as this is regression issue?
> Thanks!

Not sure what the process is here and what's expected of me.
The risky-ness of the patch was described for the 2.2 approval (Comment 17).

Isn't it a pure relman issue now?

Comment 25

[Shally Li（leave from Mozilla）]

The v2.2&master has verified, so clear 'verifyme' keywords.