STR: 1. Visit a page that can be added to your reading list. e.g.: http://convolv.es/blog/2015/03/25/wifi-debug-fxos/ 2. Hover the URL bar so the "+" button shows up. 3. Right-click the "+" button. (e.g. to see if it has a context-menu) ACTUAL RESULTS: The page is added to my reading list, as if I'd left-clicked the button. EXPECTED RESULTS: Nothing should happen (aside from perhaps a context-menu appearing). For comparison, if I right-click the reload button, or the "site identity button" (both inside the URL bar), or if I right-click the "Home" button, I get the standard Firefox-toolbar context menu. If I right-click blank space in the URL bar, I get the standard textfield context menu. I'd expect that right-clicking the "+" button should have one of those two behaviors, for consistency.
Actually, sorry -- the ACTUAL RESULTS are that the page is added to my reading list, *and* a context-menu appears. But, only the context-menu should appear.
I'm running a 64-bit Linux nightly: 39.0a1 (2015-03-27)
This is also reproducible on Windows 8.1 (x64).
Points: --- → 1
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #8588144 - Flags: review?(jaws)
Attachment #8588144 - Flags: review?(jaws) → review+
Target Milestone: --- → Firefox 40
Comment on attachment 8588144 [details] [diff] [review] patch Approval Request Comment [Feature/regressing bug #]: Reader View [User impact if declined]: as described in comment 0 [Describe test coverage new/current, TreeHerder]: no additional test coverage, unlikely to regress. There is coverage ensuring this won't break RV. [Risks and why]: very low risk, simple button check [String/UUID change made/needed]: none
Comment on attachment 8588144 [details] [diff] [review] patch Should be in 38 beta 3
I'm still seeing this issue on Beta 38.0b4-build1 (20150413143743), Aurora 39.0a2 (2015-04-16) and Nightly 40.0a1 (2015-04-15), using Ubuntu 14.04 (x64), Windows 7 (x64) and Mac OS X 10.9.5. Right-clicking the (+) button adds the page to reading list and brings up the context menu.
The patch on this bug fixed the wrong issue. I've filed bug 1155304 to track the issue that this bug was filed for.
Summary: If I right-click the reading list "+" button (in URL bar), the page gets added to my reading list → If I right-click the reading list Reader Mode button (in URL bar), the page enters Reader Mode
Summary: If I right-click the reading list Reader Mode button (in URL bar), the page enters Reader Mode → If I right-click the Reader Mode button (in URL bar), the page enters Reader Mode
Verified fixed on Beta 38.0b5-build1 (20150416143048), Aurora 39.0a2 (2015-04-19) and Nightly 40.0a1 (2015-04-19), using Ubuntu 14.04 (x64), Windows 8.1 (x64) and Mac OS X 10.9.5.
You need to log in before you can comment on or make changes to this bug.