Closed
Bug 1148571
Opened 9 years ago
Closed 9 years ago
Dispatch AudioSink notifications asynchronously
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: bholley, Assigned: bholley)
References
Details
Attachments
(1 file)
5.68 KB,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
I wrote patches for this in bug 1145686, but it looks like it's causing a b2g ICS emulator timeout in dom/media/test/test_loop.html that I don't have time to dig into right now. So I'm separating this patch out and landing the rest.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8584755 -
Flags: review+
Assignee | ||
Comment 2•9 years ago
|
||
Bisecting this a little bit more to see where the problem is: https://treeherder.mozilla.org/#/jobs?repo=try&revision=504b71481660 https://treeherder.mozilla.org/#/jobs?repo=try&revision=02d87bbf214d https://treeherder.mozilla.org/#/jobs?repo=try&revision=1085a0e4d428
Assignee | ||
Comment 3•9 years ago
|
||
So it turns out that the b2g jobs that run the media tests are hidden now because they're generally failing all over the place. It's not clear to me whether the test_loop.html stuff represents a new issue or not, but I can't reliably debug it with try right now, and I need it for bug 1151656 - so I'm going to push it. Sorry in advance for any trouble it causes people, but it's pretty difficult to debug failures that only show up intermittently+b2g only.
Blocks: 1151656
Assignee | ||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/b42d9bedcbf0 (Note - a recent green try run with this + a bunch of other patches is https://treeherder.mozilla.org/#/jobs?repo=try&revision=fbff16cd9779 )
Assignee | ||
Comment 5•9 years ago
|
||
(In reply to Bobby Holley (:bholley) from comment #4) > (Note - a recent green try run with this + a bunch of other patches is > https://treeherder.mozilla.org/#/jobs?repo=try&revision=fbff16cd9779 ) Looks like this patch wasn't actually in that push for some reason, and it had a typo. Fixing that with Ryan's permission: https://hg.mozilla.org/integration/mozilla-inbound/rev/63c495f3e709
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b42d9bedcbf0 https://hg.mozilla.org/mozilla-central/rev/63c495f3e709
Assignee: nobody → bobbyholley
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•