114861 - Sidebar missing all content

Status: VERIFIED FIXED

(SeaMonkey :: Sidebar, defect)

Description

[Tracy Walker [:tracy]]

seen on commercial builds:

windows 2001-12-12-06-trunk
linux 2001-12-12-06-trunk
mac build delayed

-launch browser
notice the sidebar is not open as default. the grippy is missing but you are 
able to click and drag open the sidebar, but there is absolutely no content; no 
tabs, nothing but gray background.

this bug is present in both classic and modern skin.

Comment 1

[sujay]

also in View menu, sidebar isn't there...also F9 key doesn't open
the sidebar...

Comment 2

[Daniel (Leaf) Nunes]

my linux 2001-12-12-06 build (mozilla) has sidebar content. probably the
commercial tree needs an update to match what happened to the mozilla tree
yesterday.

Comment 3

[Asa Dotzler [:asa]]

commercial only. The sidebar is functional in Mozilla builds. This new close
button has a couple problems and I suspect this is realted to our substantial
increase in new window time but those are other bugs. Perhaps these changes
should just be removed until after the milestone.

Comment 4

[Suresh]

on linux, I get this error.

Undefined entity...tooltiptext="&sidebar.close.tooltip;

file:http://lxr.mozilla.org/seamonkey/source/xpfe/components/sidebar/resources/s
idebarOverlay.xul#103

Comment 5

[Suresh]

ok...removeing the tooltip stuff fixes the problem for me..

Comment 6

[Suresh]

Attachment: patch attached...testing on linux....

Comment 7

[Suresh]

ok..this fixes the problem on linux too. looking for r/sr.

Comment 8

[Scott MacGregor]

Comment on attachment 61469 [details] [diff] [review]
patch attached...testing on linux....

sr=mscott....

Comment 9

[(not reading, please use [e-mail] instead)]

Comment on attachment 61469 [details] [diff] [review]
patch attached...testing on linux....

r=sspitzer, to unblock the tree.

I'm assuming that tooltip is desired, so we should let samir know, so he can
add it back.

Comment 10

[(not reading, please use [e-mail] instead)]

are just not including this dtd file?

/xpfe/components/sidebar/resources/locale/en-US/sidebarOverlay.dtd, line 44 -- 
<!ENTITY sidebar.close.tooltip "Close">

Comment 11

[Suresh]

I just removed the tooltip stuff. 

Samir, pls make sure you add tooltip back later on.! Thanks.

Comment 12

[Samir Gehani]

Ack, no.  The right fix is to add the tooltip label in the forked commercial
sidebarOverlay.dtd.  I guess this is in already.  

Suresh,
Thanks for cleaning up after me even if it is only an interim measure.  Sorry
about that.

Comment 13

[nhottanscp]

What's the status of this bug, is this still a smoketest blocker?

Comment 14

[R.K.Aa.]

*** Bug 114913 has been marked as a duplicate of this bug. ***

Comment 15

[Suresh]

marking fixed.

Comment 16

[Tracy Walker [:tracy]]

verified fixed on commercial builds:

windows 2001-12-13-06-trunk
linux 2001-12-13-06-trunk
mac 2001-12-13-06-trunk