Closed Bug 1148639 Opened 7 years ago Closed 7 years ago

Update libvpx

Categories

(Core :: Audio/Video, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: rillian, Assigned: rillian)

References

Details

Attachments

(3 files, 5 obsolete files)

It's been a while since we updated libvpx, primarily because they haven't made a release. This bug is to update us to whatever commit chrome was using when I started this patch.
Assignee: nobody → giles
Attached patch Part 2: Update libvpx (obsolete) — Splinter Review
Result of running the new update script on commit afad1a84c15b9af8298a37c0fa449e0af40931fd.
Attached file Part 2: Update libvpx v2 (obsolete) —
forgot to add new source files.
Attachment #8584833 - Attachment is obsolete: true
Blocks: 1137614
Blocks: 1151175
Move a couple of asm files which assume they're on x86_64.
Attachment #8584832 - Attachment is obsolete: true
Attached patch Part 2 - Update libvpx v3 (obsolete) — Splinter Review
Result of running the new update script.
Attachment #8584847 - Attachment is obsolete: true
FYI, this doesn't build locally for me with MSVC2013.

Unified_c_media_libvpx7.c
Warning: C4005 in media\libvpx\vpx_config_x86_64-win64-vs12.h: 'HAVE_STDINT_H' : macro redefinition
media\libvpx\vpx_config_x86_64-win64-vs12.h(34) : warning C4005: 'HAVE_STDINT_H' : macro redefinition
        objdir-fx-64\media\libvpx\../../dist/include/mozilla-config.h(37) : see previous definition of 'HAVE_STDINT_H'
Unified_c_media_libvpx6.c
Warning: C4005 in media\libvpx\vpx_config_x86_64-win64-vs12.h: 'HAVE_STDINT_H' : macro redefinition
media\libvpx\vpx_config_x86_64-win64-vs12.h(34) : warning C4005: 'HAVE_STDINT_H' : macro redefinition
        objdir-fx-64\media\libvpx\../../dist/include/mozilla-config.h(37) : see previous definition of 'HAVE_STDINT_H'
media\libvpx\vp9\decoder\./vp9_thread.h(49) : error C2059: syntax error : 'type'
media\libvpx\vp9\decoder\./vp9_thread.h(62) : error C2143: syntax error : missing ')' before '('
media\libvpx\vp9\decoder\./vp9_thread.h(62) : error C2091: function returns function
media\libvpx\vp9\decoder\./vp9_thread.h(62) : error C2143: syntax error : missing ')' before ','
Filed :  https://code.google.com/p/webm/issues/detail?id=986

To look into the issue.
This isn't an issue with the libvpx build system. It has something to do with the include order in the c file : Unified_c_media_libvpx7.c 

We recommend someone familiar with the build system to further separate the libvpx sources.
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #6)

> media\libvpx\vp9\decoder\./vp9_thread.h(49) : error C2059: syntax error :
> 'type'

Yeah, sorry, I should have been updating the bug. Was trying to remember how to build on windows to find a fix for that one. Jim's theory of unified build bustage is a likely one. There have been several similar issues with the updated code.
Rebase after bug 1061339.
Attachment #8589366 - Attachment is obsolete: true
Attachment #8589367 - Attachment is obsolete: true
Disable unified build for all libvpx source files. This avoids problems with the previous patch set on MSVC and possible other miscompilation issues. f=derf from irc.
Attachment #8593090 - Flags: review?(kinetik)
Attachment #8593091 - Flags: review?(kinetik)
Attachment #8593093 - Flags: review?(kinetik)
Attachment #8593093 - Flags: review?(kinetik) → review+
Attachment #8593091 - Flags: review?(kinetik) → review+
Attachment #8593090 - Flags: review?(kinetik) → review+
Thanks for the review!
Blocks: 1175220
You need to log in before you can comment on or make changes to this bug.