Closed Bug 1148699 Opened 5 years ago Closed 5 years ago

[EME] Race in CDM Session IDs

Categories

(Core :: Audio/Video, defect)

x86_64
Windows 8.1
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox38 --- fixed
firefox39 --- fixed

People

(Reporter: eflores, Assigned: eflores)

References

Details

Attachments

(1 file)

No description provided.
Attached patch race-fix.patchSplinter Review
Well. That was silly.
Attachment #8584951 - Flags: review?(cpearce)
Attachment #8584951 - Flags: review?(cpearce) → review+
Must uplift...
Flags: needinfo?(cpearce)
https://hg.mozilla.org/mozilla-central/rev/082719ae4d05
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Comment on attachment 8584951 [details] [diff] [review]
race-fix.patch

Approval Request Comment
[Feature/regressing bug #]: EME.
[User impact if declined]: The patch in bug 1147689 (already approved for uplift) has a bug, so we won't handle some cases where there are multiple videos playing correctly; some videos will end up unecessarily having their quality reduced.
[Describe test coverage new/current, TreeHerder]: Local and partner testing
[Risks and why]: Low; this only affects EME, and should be limited to edge cases
[String/UUID change made/needed]: None.
Attachment #8584951 - Flags: approval-mozilla-aurora?
Given that this is a fix for the patches in Bug 1147689 and that they're approved and waiting to land on aurora, I'm going to land this now and beg forgiveness from release management rather than wait for approval, since time is so tight for making the uplift tomorrow...
https://hg.mozilla.org/releases/mozilla-aurora/rev/2ca36c0b7ccd
Whiteboard: RelMan: I am sorry, I am a bad person. Will buy you all a drink next time I see you.
RelMan: I am sorry, I am a bad person. Will buy you all a drink next time I see you.
Flags: needinfo?(cpearce)
Whiteboard: RelMan: I am sorry, I am a bad person. Will buy you all a drink next time I see you.
Ah ah, I understand (but you still owe us a drink :)
Since this landed on central for 39 and aurora for 38, we can clear the approval request flag, right? Does anything else need to happen here?
Flags: needinfo?(sledru)
Yes, sorry, I should have done it but I got distracted by the drink idea :)
Flags: needinfo?(sledru)
Attachment #8584951 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.