1148711 - nsCSSParser::Parse{Property,Variable} always return NS_OK

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Cameron McCormack (:heycam)]

Attachment: patch

Let's remove the nsresult return values from nsCSSParser::Parse{Property,Variable}, as they always return NS_OK.

Comment 1

[Daniel Holbert [:dholbert]]

Comment on attachment 8584969 [details] [diff] [review]
patch

Review of attachment 8584969 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, just one comment nit:

::: layout/style/nsDOMCSSDeclaration.cpp
@@ +337,5 @@
>      if (decl != olddecl) {
>        delete decl;
>      }
> +    // Don't throw an exception if there was a parse error.
> +    return NS_OK;

The wording here is a bit ambiguous & might benefit from a tweak.  Right now, it can be mis-interpreted as: "Now we're maybe going to throw an exception, except don't do that if there was a parse error". But really what you're trying to say is, *we know there was a parse error*, and we don't throw for that.

Maybe reword something like this, if this matches the meaning you're going for:
  // Parsing failed -- but we don't throw an exception for that.

(You have this code-comment in two different places -- if you tweak it, make sure to change both of them.

Comment 2

[Cameron McCormack (:heycam)]

Comment tweak sounds fine, thanks.

https://hg.mozilla.org/integration/mozilla-inbound/rev/5fe056ac3907

Comment 3

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/5fe056ac3907