1148723 - [Flame][Settings]The SIM PIN input box is overlapped and can't be shown.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Elie]

Attachment: 2015-03-28-16-05-51.png

[1.Description]:
[Flame][v2.2&3.0][Homescreen]Launch gallery in landscape,call up the SIM PIN dialog by enable/disable airplane mode,you can see the pin input box is overlaped and can't be shown.
Attchment:2015-03-28-16-05-51.png and logcat_1653.txt
Happen time:16:53

[2.Testing Steps]: 
1.Inser SIM card with pin enable
2.Launch Gallery
3.Switch to landscape ->Drag down notification bar and enable airplane mode->disable airplane mode
>>SIM PIN input dialog pops up

[3.Expected Result]: 
3.The SIM PIN input box should not overlaped and can be shown.

[4.Actual Result]: 
3.The SIM PIN input box is overlaped and can't be shown.

[5.Reproduction build]: 
Device: Flame 2.2 (affected)
Build ID               20150327162502
Gaia Revision          473cd63f53c855299b719285d9b95e3f2910782f
Gaia Date              2015-03-27 20:14:43
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/b358619def45
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150327.194944
Firmware Date          Fri Mar 27 19:49:53 EDT 2015
Bootloader             L1TC000118D0

Device: Flame 3.0: affected
Build ID               20150327160203
Gaia Revision          9cc496cecc37d7a29f9279827cdf6e4891211f67
Gaia Date              2015-03-27 13:55:18
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/44e454b5e93b
Gecko Version          39.0a1
Device Name            flame
Firmware(Release)      4.4.2

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
Free test

Comment 1

[Elie]

Attachment: logcat_1653.txt

Comment 2

[William Hsu [:whsu]]

Hi, Elie,

Can it be reproduced on v2.1?

Comment 3

[Elie]

(In reply to William Hsu [:whsu] from comment #2)
> Hi, Elie,
> 
> Can it be reproduced on v2.1?

Hi William,This issue can be reproduced on flame 2.1.
Flame 2.1:
Build ID               20150402161201
Gaia Revision          4e7d880defb83c25b49462479c02b3e64d21f421
Gaia Date              2015-04-02 18:26:54
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/e76f5e7a264d
Gecko Version          34.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150402.194043
Firmware Date          Thu Apr  2 19:40:52 EDT 2015
Bootloader             L1TC000118D0
Reproduce rate         10/10

Comment 4

[William Hsu [:whsu]]

[Blocking Requested - why for this release]:

This bug seems to exist on FxOS for a long time.
Bad user experience. Suggest to fix on latest branch.

Many thanks.

Comment 5

[Gregor Wagner [:gwagner]]

Should we just disable landscape mode for the sim overlay?

Comment 6

[Gregor Wagner [:gwagner]]

For assigning.

Comment 7

[Gregor Wagner [:gwagner]]

Is this still an issue?

Comment 8

[Pi Wei Cheng [:piwei] (inactive)]

This issue is still reproducible on today's Flame 3.0 nightly. The SIM entering field is obscured by the keyboard in landscape mode. The page can't be scrolled so there's no way to make the field visible (other than tilting the phone back to portrait mode).

Device: Flame
BuildID: 20150522010227
Gaia: 1126d8bee559f7cde675df2fcc6c196da9cfeba1
Gecko: 3e737d30f842
Gonk: 040bb1e9ac8a5b6dd756fdd696aa37a8868b5c67
Version: 41.0a1 (3.0 Master) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:41.0) Gecko/41.0 Firefox/41.0

Comment 9

[Alberto Pastor [:albertopq]]

I'm not sure what's the fix here... There is no more space to show the dialog. Should the dialog be always portrait, may be? Asking UX.

Comment 10

[Rob MacDonald [:robmac]]

Keep it in portrait for now because it's obviously not working in landscape. NI'ing Carrie as the dual sim owner as an FYI. 

Alberto, Michael....Is there any way we can easily find out if this dialog is used in other apps? I suspect there are other similar bugs and we should find a more permanent answer to this.

Comment 11

[Michael Henretty [:mikehenrty][:mhenretty]]

Alberto, do you want to take this one?

Comment 12

[Alberto Pastor [:albertopq]]

Sure, Michael.

Rob, enabling/disabling airplane mode (via power button or utility tray) on every app, will make the SIM PIN dialog appear. It just depends on the container app to be rotated.

Comment 13

[Alberto Pastor [:albertopq]]

Attachment: Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/30372

Comment 14

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8614117 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/30372

Hmmm, this didn't fix it for me. STR with patch,

1.) Enable SIM pin
2.) Open up browser
3.) Turn airplane mode on and then back off again
4.) After SIM PIN dialog appears, rotate phone

Result: the dialog rotates, and so orientation is not locked.

Perhaps I am missing something?

Comment 15

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8614117 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/30372

Ahhh sorry, user error. My network failed during the fetch, so I hadn't successfully pulled down your code before flashing.

It works great.

Comment 16

[Alberto Pastor [:albertopq]]

master: https://github.com/mozilla-b2g/gaia/commit/b25e851d89db9ab91158b4405545af2bf7e0f80f

Comment 17

[Shally Li（leave from Mozilla）]

This bug has been verified as pass on latest Nightly build of Flame v3.0 and Nexus 5 v3.0 by the STR in Comment 0 and Comment 14.

Actual results: The PIN input dialog is shown as portrait mode normally. 
See attachment: verified_v3.0.mp4
Reproduce rate: 0/6


Device: Flame v3.0 build(Pass)
Build ID               20150603160203
Gaia Revision          45dc6306cf502a4f00ae9f8bd8293a8a3a37c07b
Gaia Date              2015-06-03 17:32:50
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/0920f2325a6d
Gecko Version          41.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150603.192042
Firmware Date          Wed Jun  3 19:20:53 EDT 2015
Bootloader             L1TC000118D0

Device: Nexus 5 v3.0 build(Pass)
Build ID               20150603160203
Gaia Revision          45dc6306cf502a4f00ae9f8bd8293a8a3a37c07b
Gaia Date              2015-06-03 17:32:50
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/0920f2325a6d
Gecko Version          41.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150603.193140
Firmware Date          Wed Jun  3 19:31:59 EDT 2015
Bootloader             HHZ12f

Comment 18

[Shally Li（leave from Mozilla）]

Attachment: verified_v3.0.mp4

Comment 19

[Sue]

Hi Hermes,
This issue still exists on latest build of Flame 2.2 by STR in comment 0. Could you please help to confirm whether this issue will uplift to 2.2 build or not? Many thanks :)

Comment 20

[Hermes Cheng (inactive after July 27, 2015)]

Won't fix for previous version.

Comment 21

[Sue]

Thanks Hermes