1148753 - Browser Content Toolbox fails to populate

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Jim Mathies [:jimm]]

STR: open a browser, browse to a site to launch the content process, open dev tool Browser Content Toolbox.

result: no information is displayed in the ui

I did a rough spot check, this regressed between the 21st and the 26th.

Comment 1

[Jim Mathies [:jimm]]

onPacket threw an exception:

Error: Server did not specify an actor, dropping packet: {"error":"unknownError","message":"error occurred while processing 'attach:TypeError:this.sourcesis undefined\nStack: ThreadActor.prototype.onAttach@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/script.js:663:5\nDSC_onPacket@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/main.js:1459:15\nChildDebuggerTransport.prototype.receiveMessage@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/transport/transport.js:734:5\nLine: 663, column: 4"}

Stack:
DebuggerClient.prototype.onPacket@resource://gre/modules/devtools/dbg-client.jsm:941:1
LocalDebuggerTransport.prototype.send/<@resource://gre/modules/devtools/dbg-client.jsm -> resource://gre/modules/devtools/transport/transport.js:561:11
makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:82:14
makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:82:14
Line: 941, column: 0

Comment 2

[Jim Mathies [:jimm]]

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=840cfd5bc971&tochange=db0409de517a

Comment 3

[Jim Mathies [:jimm]]

inbound:

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=f0a4844f0ccd&tochange=43ef69c1f6b5

not seeing much here, I'll try some local backouts.

Comment 4

[Jim Mathies [:jimm]]

Last good revision: 840cfd5bc971 (2015-03-24)
First bad revision: db0409de517a (2015-03-25)

I'm not having any luck finding the regression push after backing out what appeared to be most likely candidates.

I can confirm though that an hg update 840cfd5bc971 fixes the problem.

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

The stack points to the debugger, so moving there. James, could this be related to the patch that moves source actors to another file?

Comment 7

[Patrick Brosset <:pbro>]

Also happens on mac.

Comment 8

[James Long (:jlongster)]

bug 1137384 did break this. I don't know why we have instances of things that look like tab actors but don't inherit from TabActor. Right now there's a loose protocol that the object needs to implement and now creating a TabSources object is part of that. It would be nice to enforce this protocol instead of just using duck typing.

I can make a patch

Comment 9

[James Long (:jlongster)]

Attachment: 1148753.patch

This should fix it. jryans let me know if someone other than you should review

Comment 10

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8585559 [details] [diff] [review]
1148753.patch

Looks good!

Comment 11

[James Long (:jlongster)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=061a7c89f8d0

We should try to land this today because an uplift is happening tonight.

Comment 12

[Brian Grinstead [:bgrins]]

(In reply to James Long (:jlongster) from comment #11)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=061a7c89f8d0
> 
> We should try to land this today because an uplift is happening tonight.

I think this has missed the boat for the merge (m-c is already approval only).  But it will be an obvious candidate for aurora uplift.

Comment 13

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

[Tracking Requested - why for this release]: Make sure we don't forget to uplift.

Comment 14

[James Long (:jlongster)]

Sounds good.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/43729f333234

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/43729f333234

Comment 17

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

James, is this ready for an uplift request?

Comment 18

[James Long (:jlongster)]

Comment on attachment 8585559 [details] [diff] [review]
1148753.patch

Approval Request Comment
[Feature/regressing bug #]: bug 1137384
[User impact if declined]: browser content toolbox is broken
[Describe test coverage new/current, TreeHerder]: I don't think we run tests against the browser content toolbix, but any tests on it should have made this known
[Risks and why]: very little risk, only touches a devtool
[String/UUID change made/needed]:

Comment 19

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8585559 [details] [diff] [review]
1148753.patch

Approved for uplift to 39; low risk fix to a regression.

Comment 20

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a5e2ccf127b8