1148791 - [Build] Cache the result of downloading modules.tar

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[Julien Wajsberg [:julienw]]

When moving between branches, or even between revisions, we need to download and redownload modules.tar all the time.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] julienw:keep-cache-for-modules.tar > mozilla-b2g:master

Comment 2

[Julien Wajsberg [:julienw]]

Comment on attachment 8585060 [details] [review]
[gaia] julienw:keep-cache-for-modules.tar > mozilla-b2g:master

Hey Ricky,

tell me what you think.

I tried moving back and forth in master timeline with the patch, and it seems to work fine. I also tried to move back and forth with versions without the patch and it works fine as well.

Comment 3

[Julien Wajsberg [:julienw]]

I'd need someone to test on MacOS X and Windows too.

NI Alexandre who could try on Windows and Etienne on MacOS X. I'd especially like to know whether "rm -rf node_modules && make node_modules" correctly downloads and install the node_modules directory.

Comment 4

[Etienne Segonzac (:etienne)]

(In reply to Julien Wajsberg [:julienw] from comment #3)
> I'd need someone to test on MacOS X and Windows too.
> 
> NI Alexandre who could try on Windows and Etienne on MacOS X. I'd especially
> like to know whether "rm -rf node_modules && make node_modules" correctly
> downloads and install the node_modules directory.

It does on yosemite.

Comment 5

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8585060 [details] [review]
[gaia] julienw:keep-cache-for-modules.tar > mozilla-b2g:master

Great job julien!! I verified it on Mac and it worked on my machine. r+ for this patch, I leaved a nit on Github so please fix it before landing thanks!

Comment 6

[Julien Wajsberg [:julienw]]

I fixed the comment :) I'll wait for Alexandre to test this on Windows before landing.

Comment 7

[Julien Wajsberg [:julienw]]

I checked with Alexandre and this is broken in the same way with/without this patch on Windows :)

The issue is that the downloaded tar contains symbolic links. But this is a separate bug.

Comment 8

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/77f55aa5f7447e5515b99aacb17cf9be300f182a

Comment 9

[GitHub Autolander Bot]

Attachment: [gaia] julienw:1148791-v2.2-uplift-modules.tar > mozilla-b2g:v2.2

Comment 10

[Julien Wajsberg [:julienw]]

Waiting for a try run for uplift.

Comment 11

[Julien Wajsberg [:julienw]]

Some tests failed but I'll assume this is "normal". All build tests passed.

a=npotb
uplifted to v2.2: 3ee276bd8ede9752054450a30546e7ecbddc6f17

Please backout if there is any issue.