Closed Bug 1148797 Opened 7 years ago Closed 5 years ago

Don't save transient Tabs into the Undo session

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox54 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 54
Tracking Flags:
Tracking Status
firefox54 --- verified

People

(Reporter: mfinkle, Assigned: JanH)

Details

Attachments

(1 file, 2 obsolete files)

Bug 1148797 - Don't offer "Undo close tab" for empty tabs with no session history.
59 bytes, text/x-review-board-request
ahunt
: review+
Details 
In SessionStore.onTabClose we should look at the session. If the session is empty or has only "about:home" or "about:privatebrowsing", we should not save the session
Assignee: nobody → jh+bugzilla
OS: Mac OS X → Android
Hardware: x86 → All
Attachment #8832190 - Attachment is obsolete: true
Attachment #8832190 - Flags: review?(mdeboer)
Attachment #8832191 - Attachment is obsolete: true
Attachment #8832191 - Flags: review?(s.kaspari)
Argh, wrong bug number, sorry.
Comment on attachment 8832216 [details]
Bug 1148797 - Don't offer "Undo close tab" for empty tabs with no session history.

https://reviewboard.mozilla.org/r/108564/#review111276

Very nice!
Attachment #8832216 - Flags: review?(ahunt) → review+
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/760e78724db9
Don't offer "Undo close tab" for empty tabs with no session history. r=ahunt
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/760e78724db9
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Verified as fixed on Nightly 54.0a1 (2017-02-09);
Device: Huawei MediaPad M2 (Android 5.1.1).
Status: RESOLVED → VERIFIED
status-firefox54: fixed → verified
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.