Closed
Bug 1148820
Opened 10 years ago
Closed 10 years ago
The JSON version of a page is missing the summary content for its translation
Categories
(developer.mozilla.org Graveyard :: API, enhancement)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Jeremie, Assigned: fs)
Details
(Whiteboard: [specification][type:bug])
What did you do?
================
Request that page in English:
https://developer.mozilla.org/en-US/docs/Glossary/AJAX$json
And the same page translated in French
https://developer.mozilla.org/fr/docs/Glossaire/AJAX$json
What happened?
==============
When you look at the
{
translations: [
{
summary: ""
}
]
}
The translation summary is provide with an empty string.
What should have happened?
==========================
The translation summary should be filled with the SEO summary extracted from the translated page.
Is there anything else we should know?
======================================
This make that the {{Glossary}} macro has to do 3 request instead of two to work. This lead to unnecessary overload on KumaScript.
| Assignee | ||
Updated•10 years ago
|
Severity: normal → enhancement
Component: General → API
| Assignee | ||
Comment 1•10 years ago
|
||
PR submitted: https://github.com/mozilla/kuma/pull/3175
Assignee: nobody → fscholz
Comment 2•10 years ago
|
||
Commits pushed to master at https://github.com/mozilla/kuma
https://github.com/mozilla/kuma/commit/79e2ee2503f67e6b7befd3c1f48d12b8f6aff7c6
Fix bug 1148820: Properly get the summary for translations in jsons
https://github.com/mozilla/kuma/commit/d79d0c21af5488be806e933f5d6de66222f3b372
Merge pull request #3175 from Elchi3/bug1148820
Fix bug 1148820: Properly get the summary for translations in jsons
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 3•10 years ago
|
||
This is pushed to production, but since the summary is put into the JSON during a page save, I'm afraid the pages have to be saved again to re-populate the value? :/
| Assignee | ||
Comment 4•10 years ago
|
||
Force-refreshing pages also works. Thanks for merging and pushing :)
(Ideally we would re-render all our documents to get this populated everywhere. We requested this several times already, but it happened only with Les' script ages ago, see also bug 1094452 for current ideas/approaches)
| Reporter | ||
Comment 5•10 years ago
|
||
While investigating that bug with Jannis, he was worried by the fact that the summary doesn't seams to be properly cached in DB. So this bug fix could lead to some performance issue. Maybe a follow up of this bug is necessary to check that out. I needinfo Jannis for his opinion on this.
Flags: needinfo?(jezdez)
| Assignee | ||
Comment 6•10 years ago
|
||
Might be related/dealt with in bug 1082616.
Updated•10 years ago
|
Flags: needinfo?(jezdez)
Updated•5 years ago
|
Product: developer.mozilla.org → developer.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•