Closed Bug 1148857 Opened 7 years ago Closed 7 years ago
HTTP 401 auth dialog doesn't pop up any more
STR: Go to a page with HTTP auth, e.g. https://staktrace.com/apps/bugmash/dashboard.php ER: Popup dialog asking for username/password AR: No dialog, goes straight to 401 error page from server. This is a recent regression on nightly (maybe last couple of days).
7 years ago
Inbound regression range: Last good revision: aef75ff8a911 First bad revision: 44e454b5e93b Pushlog: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=aef75ff8a911&tochange=44e454b5e93b
This fixes it for me on a local build. The string is needed at http://mxr.mozilla.org/mozilla-central/source/mobile/android/components/PromptService.js?rev=687318d464a5#621
Assignee: nobody → bugmail.mozilla
Attachment #8585429 - Flags: review?(liuche)
The fix might be to change to use "rememberButton" here: http://mxr.mozilla.org/mozilla-central/source/mobile/android/components/PromptService.js#621
That works too.
Attachment #8585505 - Flags: review?(liuche)
Comment on attachment 8585505 [details] [diff] [review] Alternate patch suggested by mfinkle Review of attachment 8585505 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for the patch, sorry about that!
Attachment #8585505 - Flags: review?(liuche) → review+
Comment on attachment 8585429 [details] [diff] [review] Patch No worries, thanks for the quick review! https://hg.mozilla.org/integration/fx-team/rev/467d7e5ce428
[Tracking Requested - why for this release]: Regression, would be great to get uplifted to 39 before Thursday to ship with Aurora enabling on Friday.
Comment on attachment 8585505 [details] [diff] [review] Alternate patch suggested by mfinkle Approval Request Comment [Feature/regressing bug #]: bug 1088220 [User impact if declined]: password dialogs for 401 response codes dont appear [Describe test coverage new/current, TreeHerder]: locally [Risks and why]: low risk; breakage from a recent change pre-merge [String/UUID change made/needed]: none
Attachment #8585505 - Flags: approval-mozilla-aurora?
Verified as fixed in build 40.0a1 (2015-03-31); Device: Motorola Razr (Android 4.1.2).
Comment on attachment 8585505 [details] [diff] [review] Alternate patch suggested by mfinkle Taking this for 39 since it sounds low risk.
Attachment #8585505 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified fixed on Firefox 39.0a2 (2015-04-02)
Margaret noticed I marked 38 affected and the regressing bug is new in 39. Was fairly sure in triage that I just miss-clicked affected. Double checked just now and I am able to log in via http auth (intranet.mozilla.org) on Firefox 38 so setting unaffected.
Based on comment 13 I will remove the qe-verify, thanks.
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.