1148857 - HTTP 401 auth dialog doesn't pop up any more

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

STR:
Go to a page with HTTP auth, e.g. https://staktrace.com/apps/bugmash/dashboard.php

ER:
Popup dialog asking for username/password

AR:
No dialog, goes straight to 401 error page from server.

This is a recent regression on nightly (maybe last couple of days).

Comment 1

[Flaviu Cos]

Inbound regression range:

Last good revision: aef75ff8a911
First bad revision: 44e454b5e93b
Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=aef75ff8a911&tochange=44e454b5e93b

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Also in logcat I see this:

W/GeckoConsole(20809): [JavaScript Error: "_doAsyncPrompt:run: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIStringBundle.GetStringFromName]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: jar:jar:file:///data/app/org.mozilla.fennec-1.apk!/assets/omni.ja!/components/PromptService.js :: pu_getLocaleString :: line 557"  data: no]
W/GeckoConsole(20809): " {file: "jar:jar:file:///data/app/org.mozilla.fennec-1.apk!/assets/omni.ja!/components/PromptService.js" line: 482}]

so I'm gonna guess it's a regression from https://hg.mozilla.org/integration/fx-team/rev/ebf592c2fa4c

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

This fixes it for me on a local build. The string is needed at http://mxr.mozilla.org/mozilla-central/source/mobile/android/components/PromptService.js?rev=687318d464a5#621

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

The fix might be to change to use "rememberButton" here:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/components/PromptService.js#621

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Attachment: Alternate patch suggested by mfinkle

That works too.

Comment 6

[Chenxia Liu [:liuche]]

Comment on attachment 8585505 [details] [diff] [review]
Alternate patch suggested by mfinkle

Review of attachment 8585505 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch, sorry about that!

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8585429 [details] [diff] [review]
Patch

No worries, thanks for the quick review!

https://hg.mozilla.org/integration/fx-team/rev/467d7e5ce428

Comment 8

[Kevin Brosnan [Ex-Mozilla]]

[Tracking Requested - why for this release]: Regression, would be great to get uplifted to 39 before Thursday to ship with Aurora enabling on Friday.

Comment 9

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8585505 [details] [diff] [review]
Alternate patch suggested by mfinkle

Approval Request Comment
[Feature/regressing bug #]: bug 1088220
[User impact if declined]: password dialogs for 401 response codes dont appear
[Describe test coverage new/current, TreeHerder]: locally
[Risks and why]: low risk; breakage from a recent change pre-merge
[String/UUID change made/needed]: none

Comment 10

[Flaviu Cos]

Verified as fixed in build 40.0a1 (2015-03-31);
Device: Motorola Razr (Android 4.1.2).

Comment 11

[Liz Henry (:lizzard) (privacy/fingerprinting team)]

Comment on attachment 8585505 [details] [diff] [review]
Alternate patch suggested by mfinkle

Taking this for 39 since it sounds low risk.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/010344056448

Comment 13

[Catalin Suciu [:csuciu]]

Verified fixed on Firefox 39.0a2 (2015-04-02)

Comment 14

[Kevin Brosnan [Ex-Mozilla]]

Margaret noticed I marked 38 affected and the regressing bug is new in 39. Was fairly sure in triage that I just miss-clicked affected. Double checked just now and I am able to log in via http auth (intranet.mozilla.org) on Firefox 38 so setting unaffected.

Comment 15

[Stefan Deiac]

Based on comment 13 I will remove the qe-verify, thanks.