1148868 - Allow OS X APZ to assume e10s as a prerequisite

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Description

[Markus Stange [:mstange]]

At the moment Mac and Windows use a different method of getting events to APZ. Mac uses a separate event thread, and Windows forwards events from the main thread of the parent process, and thus only benefits in e10s mode.
We should make Mac follow Windows initially so that we can benefit from the work that has gone into it. If it turns out that APZ might be ready for shipping before e10s is, we can re-enable the separate event thread on Mac and make it work correctly.

Comment 1

[Markus Stange [:mstange]]

Attachment: MozReview Request: bz://1148868/mstange

/r/6275 - Bug 1148868 - Put the APZ event thread on Mac behind a pref layers.async-pan-zoom.separate-event-thread that defaults to false.
/r/6277 - Bug 1148868 - Make APZ wheel handling handle pixel scrolling.
/r/6279 - Bug 1148868 - Forward Mac wheel events to APZ.

Pull down these commits:

hg pull review -r 38103c4ebfe4ddd1343bd0a4e0c4c8e043444c65

Comment 2

[Markus Stange [:mstange]]

https://reviewboard.mozilla.org/r/6277/#review5245

::: widget/InputData.h
(Diff revision 1)
>      // "pixel". For apz, we currently only support "line" mode.

Oops, I guess I need to update this comment.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

https://reviewboard.mozilla.org/r/6277/#review5251

::: gfx/layers/apz/src/APZCTreeManager.cpp
(Diff revision 1)
> +DeltaTypeForDeltaMode(uint32_t aDeltaMode)

I would rather put this function in InputData.h than in APZCTreeManager.cpp so it can be reused more easily

Comment 4

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 8585126 [details]
MozReview Request: bz://1148868/mstange

https://reviewboard.mozilla.org/r/6273/#review5261

Comment 5

[Markus Stange [:mstange]]

Attachment: just the pixel scrolling patch

like this?

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8587047 [details] [diff] [review]
just the pixel  scrolling patch

Review of attachment 8587047 [details] [diff] [review]:
-----------------------------------------------------------------

r+ but this will need rebasing around bug 1139220 (parts 3 and 5 at least). Not sure who will land first.

Comment 7

[David Anderson [:dvander] - inactive, e-mail if emergency]

I did a try run w/ APZ forced on and the test fixes from bug 1140293:
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=8375ad7f0f34

When I also apply pixel scrolling support:
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=cf436a97b40c

We have some additional failures in M-2 and M-oth.

Comment 8

[Markus Stange [:mstange]]

List of the new failing tests:
> TEST-UNEXPECTED-FAIL | dom/events/test/test_bug574663.html | Normal scrolling should scroll - didn't expect 0, but got it
> TEST-UNEXPECTED-FAIL | dom/events/test/test_bug574663.html | Test timed out. - expected PASS
> TEST-UNEXPECTED-FAIL | dom/events/test/test_bug607464.html | Pixel scrolling should have finished after one refresh driver iteration. We shouldn't be scrolling smoothly, even though the pref is set. - got 0, expected 15
> TEST-UNEXPECTED-FAIL | dom/events/test/test_wheel_default_action.html | doTestScroll(aSettings=all delta values are not customized), Scroll to only bottom by oblique pixel wheel event with overflow-x: hidden: not scrolled down, got 1000 - expected PASS
> TEST-UNEXPECTED-FAIL | layout/generic/test/test_bug632379.xul | Popup should open in the same place when the menu is scrolled - got 52, expected 32
> TEST-UNEXPECTED-FAIL | toolkit/content/tests/chrome/test_mousescroll.xul | testRichListbox(richlistbox): vertical, starting 5 delta -32 lineOrPageDeltaY -1 aDeltaMode 0 - got 0, expected -1

Comment 9

[Markus Stange [:mstange]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fb666f5c94ec
https://hg.mozilla.org/integration/mozilla-inbound/rev/cbe20929107f
https://hg.mozilla.org/integration/mozilla-inbound/rev/840167106b0d
https://hg.mozilla.org/integration/mozilla-inbound/rev/dee48550f52c

Comment 10

[Markus Stange [:mstange]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9684ebd911b4

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/fb666f5c94ec
https://hg.mozilla.org/mozilla-central/rev/cbe20929107f
https://hg.mozilla.org/mozilla-central/rev/840167106b0d
https://hg.mozilla.org/mozilla-central/rev/dee48550f52c
https://hg.mozilla.org/mozilla-central/rev/9684ebd911b4

Comment 13

[Markus Stange [:mstange]]

Attachment: MozReview Request: Bug 1148868 - Put the APZ event thread on Mac behind a pref layers.async-pan-zoom.separate-event-thread that defaults to false.

Comment 14

[Markus Stange [:mstange]]

Attachment: MozReview Request: Bug 1148868 - Make APZ wheel handling handle pixel scrolling.

Comment 15

[Markus Stange [:mstange]]

Attachment: MozReview Request: Bug 1148868 - Forward Mac wheel events to APZ.