Message string for SMTP server connection error is incorrect. File: composeMsgs.properties, key: smtpSendRefused

RESOLVED FIXED in Thunderbird 40.0

Status

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: iacchi, Assigned: sshagarwal)

Tracking

({regression})

unspecified
Thunderbird 40.0
Dependency tree / graph

Thunderbird Tracking Flags

(thunderbird40 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

In composeMsgs.properties, the key smtpSendRefused shows the text "The message could not be sent because connecting to Outgoing server (SMTP) %S failed. The server may be unavailable or is refusing Outgoing server (SMTP) connections. Please verify that your Outgoing server (SMTP) settings are correct and try again."

The previous instance of the string only reported "SMTP server" instead of "Outgoing server (SMTP)". This change is ok for the first and the last part of the sentence, but "is refusing Outgoing server (SMTP) connections" makes no sense, it should be "is refusing SMTP connections".
Blocks: 952493
Posted patch Patch v1 (obsolete) — Splinter Review
Attachment #8590430 - Flags: review?(iann_bugzilla)
Comment on attachment 8590430 [details] [diff] [review]
Patch v1

Sorry it has issues.
Attachment #8590430 - Attachment is obsolete: true
Attachment #8590430 - Flags: review?(iann_bugzilla)
Posted patch Patch v1.1Splinter Review
I forgot to change the string key. This patch fixes the issue.

Thanks.
Attachment #8590441 - Flags: review?(iann_bugzilla)
Component: MailNews: Composition → Composition
Product: SeaMonkey → MailNews Core
Assignee: nobody → syshagarwal
Keywords: regression
Attachment #8590441 - Flags: review?(iann_bugzilla) → review+
Status: NEW → ASSIGNED
Thanks.
Keywords: checkin-needed
Comment on attachment 8590441 [details] [diff] [review]
Patch v1.1

a=me for SeaMonkey CLOSED TREE
https://hg.mozilla.org/comm-central/rev/a195e2c4d205
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 40.0
You need to log in before you can comment on or make changes to this bug.