1148962 - Use TakeOwnershipOfErrorReporting in CPOW code

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: patch

CPOW code is supposed to report all errors back to the calling process [1]. That's not actually working now; it always seems to report the exception as |undefined|. I think this should fix it.

[1] http://mxr.mozilla.org/mozilla-central/source/js/ipc/WrapperAnswer.cpp#29

Comment 1

[Bobby Holley (:bholley)]

Comment on attachment 8585218 [details] [diff] [review]
patch

Review of attachment 8585218 [details] [diff] [review]:
-----------------------------------------------------------------

Can you pass an AutoJSAPI& to fail (rather than cx - note that AutoEntryScript inherits AutoJSAPI), and use the StealException API instead? We're trying to wean exception handling off of the cx-based APIs.

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: patch v2

Comment 3

[Bobby Holley (:bholley)]

Comment on attachment 8585745 [details] [diff] [review]
patch v2

Review of attachment 8585745 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, thank you. I didn't realize how many changes this would be - sorry if it was a pain.

Comment 4

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/044dad7f5b5c

Don't worry about it. Just an easy search and replace.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/044dad7f5b5c