Closed Bug 1148962 Opened 5 years ago Closed 5 years ago

Use TakeOwnershipOfErrorReporting in CPOW code

Categories

(Core :: JavaScript Engine, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: billm, Assigned: billm)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
CPOW code is supposed to report all errors back to the calling process [1]. That's not actually working now; it always seems to report the exception as |undefined|. I think this should fix it.

[1] http://mxr.mozilla.org/mozilla-central/source/js/ipc/WrapperAnswer.cpp#29
Attachment #8585218 - Flags: review?(bobbyholley)
Comment on attachment 8585218 [details] [diff] [review]
patch

Review of attachment 8585218 [details] [diff] [review]:
-----------------------------------------------------------------

Can you pass an AutoJSAPI& to fail (rather than cx - note that AutoEntryScript inherits AutoJSAPI), and use the StealException API instead? We're trying to wean exception handling off of the cx-based APIs.
Attachment #8585218 - Flags: review?(bobbyholley)
Attached patch patch v2Splinter Review
Attachment #8585218 - Attachment is obsolete: true
Attachment #8585745 - Flags: review?(bobbyholley)
Comment on attachment 8585745 [details] [diff] [review]
patch v2

Review of attachment 8585745 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, thank you. I didn't realize how many changes this would be - sorry if it was a pain.
Attachment #8585745 - Flags: review?(bobbyholley) → review+
https://hg.mozilla.org/mozilla-central/rev/044dad7f5b5c
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.