splitter in compose window can be resized down to completely obscure composition area

RESOLVED FIXED in Thunderbird 40.0

Status

--
trivial
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: aceman, Assigned: aceman)

Tracking

({ux-error-prevention})

Trunk
Thunderbird 40.0
ux-error-prevention

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

2.33 KB, patch
iann_bugzilla
: review+
Details | Diff | Splinter Review
(Assignee)

Description

4 years ago
In the compose window, the splitter separating the compose area and the addressing widget can be dragged down completely to hide the compose area. Is that wanted? Should we set a minheight on the <editor id="content-frame"> element?
(Assignee)

Updated

4 years ago
Flags: needinfo?(mkmelin+mozilla)
Flags: needinfo?(josiah)
Yes we should impose some minimal size for the compose area.
Flags: needinfo?(mkmelin+mozilla)
(Assignee)

Comment 2

4 years ago
Created attachment 8586932 [details] [diff] [review]
patch
Attachment #8586932 - Flags: review?(mkmelin+mozilla)
Attachment #8586932 - Flags: review?(iann_bugzilla)
Comment on attachment 8586932 [details] [diff] [review]
patch

Review of attachment 8586932 [details] [diff] [review]:
-----------------------------------------------------------------

Looks reasonable, but if you're touching it please move the id attr first.
Attachment #8586932 - Flags: review?(mkmelin+mozilla) → review+
(Assignee)

Comment 4

4 years ago
Created attachment 8588371 [details] [diff] [review]
patch v1.1

Thanks. I have done the same thing for Seamonkey, however I have not tested if it actually works.
Attachment #8586932 - Attachment is obsolete: true
Attachment #8586932 - Flags: review?(iann_bugzilla)
Attachment #8588371 - Flags: review?(iann_bugzilla)
(Assignee)

Updated

4 years ago
Status: NEW → ASSIGNED
Flags: needinfo?(josiah)

Comment 5

4 years ago
Not sure if this happens on TB as well, but if you keep dragging the splitter down then the bottom of the window keeps jumping further down until it is off the bottom of the screen. Not sure if this intended / expected.
Flags: needinfo?(acelists)
(Assignee)

Comment 6

4 years ago
No, I can't see that. On TB the splitter just hits "a wall" and does not move further. The window itself does not move or enlarge. With the patch the "wall" is 100px above the status bar of the window. Without the patch the wall is 0px above the status bar so the compose area is completely obscured.

But I have tried to install Seamonkey (the latest version for win32 I found is 2.34a1). Without the patch I could drag the splitter BELOW the bottom edge of the compose window. So it obscured the status bar and vanished behind the bottom of the window. The bottom did not move so it clipped the splitter and everything. The patch only had the effect that the splitter pushed the status bar 100px before itself. But they still could be dragged below the window bottom. I found out this effect can be disabled by removing the "resizeafter=grow" attribute from the splitter. That attribute is used nowhere else in the tree, except 2 uses in SM.
Flags: needinfo?(acelists) → needinfo?(iann_bugzilla)
(Assignee)

Comment 7

4 years ago
Neil, do you know if resizeafter=grow on splitters is actually still useful/needed for SM?
It seems it is the only user left: http://mxr.mozilla.org/comm-central/search?string=resizeafter&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central
Flags: needinfo?(neil)

Comment 8

4 years ago
(In reply to aceman from comment #7)
> Neil, do you know if resizeafter=grow on splitters is actually still
> useful/needed for SM?
I believe it's needed for bug 60864, although it might be possible to work around the problem in code (see bug 514416 for a similar problem involving splitters).
Flags: needinfo?(neil)

Comment 9

4 years ago
I think Neil answered the query.
Flags: needinfo?(iann_bugzilla)
(Assignee)

Comment 10

4 years ago
OK, I see. But TB is not affected by bug 60864 even without resizeafter=grow. Maybe because the addressing area can't be completely collapsed. And it also does not have the collapsible toolbars. And the side-effects (dragging splitter and status bar outside of window?!) of resizeafter=grow in SM seem crazy to me, maybe even worse than bug 60864 :)

But we do not need to fix that in this bug.
Ian, just decide whether the patch here adds any value for Seamonkey. If not, I can easily drop the SM part.
Flags: needinfo?(iann_bugzilla)

Comment 11

4 years ago
Comment on attachment 8588371 [details] [diff] [review]
patch v1.1

I guess this is better than existing behaviour r=me
Flags: needinfo?(iann_bugzilla)
Attachment #8588371 - Flags: review?(iann_bugzilla) → review+
(Assignee)

Comment 12

4 years ago
Thanks.
Keywords: checkin-needed

Updated

4 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 40.0
You need to log in before you can comment on or make changes to this bug.