1149114 - [Flame][Homescreen]The SIM pin view does not fit the screen.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Elie]

[1.Description]:
[Flame][v2.2&3.0][Homescreen] Enter camera, switch to landscape, and then return to home. Invoke the SIM pin view by enabling/disabling airplane mode, you will find that the view does not fit the screen.
Attachment:VIDEO0321_Compress.MP4 and logcat_1454.txt
Happen time:14:54


[2.Testing Steps]: 
Precondition: Insert SIM card with pin enable.
1.Launch Camera.
2.Switch to Landscape->Press Home button.
3.Drag down notification bar ->Enable Airplane mode->disable airplane mode.


[3.Expected Result]: 
3.SIM pin screen pops up, and this view fits the screen.

[4.Actual Result]: 
3.SIM pin screen pops up, you will find that the view does not fit the screen.

[5.Reproduction build]: 
Flame 2.2: affected
Build ID               20150329002502
Gaia Revision          473cd63f53c855299b719285d9b95e3f2910782f
Gaia Date              2015-03-27 20:14:43
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/4b13c4254e2f
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150327.194944
Firmware Date          Fri Mar 27 19:49:53 EDT 2015
Bootloader             L1TC000118D0

Flame 3.0: Affected
Build ID               20150329010203
Gaia Revision          67ad91f3f660b1f16b354ee4c5159ddc5a74d149
Gaia Date              2015-03-28 10:02:40
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/385840329d91
Gecko Version          39.0a1
Device Name            flame
Firmware(Release)      4.4.2

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
Free test

Comment 1

[Elie]

Attachment: VIDEO0321_Compress.MP4

Comment 2

[Elie]

Attachment: logcat_1454.txt

Comment 3

[Hermes Cheng (inactive after July 27, 2015)]

This issue occurs when using an app which has Landscape mode (Camera, Gallery, and etc.)
Chris, could you take a look?

Comment 4

[Hermes Cheng (inactive after July 27, 2015)]

Sorry, I think it is Settings issue. fw NI to Arthur.

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Alive, any ideas?

Comment 6

[howie [:howie]]

Triage: blocking.

Comment 7

[(inactive after 6/18) Alive Kuo [:alive]]

Alberto, maybe not a SIM PIN dialog issue but system dialog issue, are you able to help here? Thanks in advance. It's fine if you have too much blockers I will find someone else.

Comment 8

[Alberto Pastor [:albertopq]]

Sure, I'll take a look

Comment 9

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:1149114-sim-landscape > mozilla-b2g:master

Comment 10

[Alberto Pastor [:albertopq]]

Comment on attachment 8586064 [details] [review]
[gaia] albertopq:1149114-sim-landscape > mozilla-b2g:master

The problem here is that we are not receiving the 'homescreenopened' event (so we are keeping the 'fullscreen' class on the system dialog). It can be fixed by listening to 'homescreenforeground' instead, but I'm not sure why we are not triggering that event. Alive, ideas?

Comment 11

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8586064 [details] [review]
[gaia] albertopq:1149114-sim-landscape > mozilla-b2g:master

It's because we are opening an inline activity from homescreen so homescreen will not be opened 'again' while the activity window is opened or closed.

I am fine with this way(using homescreen foreground), but I wonder if 'hierarchytopmostwindowchanged' could help to reduce the xxxxforeground/xxxopened event usage here - could you try with that?

Comment 12

[Alberto Pastor [:albertopq]]

Comment on attachment 8586064 [details] [review]
[gaia] albertopq:1149114-sim-landscape > mozilla-b2g:master

Hi Alive, I don't think we are opening an inline activity in this case. I believe you are thinking on bug 1144591. In any case, hierarchytopmostwindowchanged seems reasonable to me. I'll investigate homescreenopened event in a diferent bug. Thanks!

Comment 13

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8586064 [details] [review]
[gaia] albertopq:1149114-sim-landscape > mozilla-b2g:master

Okay, thanks for working on this!

Comment 14

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/75da19241753bdbe8ff3669dec5707889bd05394

Comment 15

[Alberto Pastor [:albertopq]]

Comment on attachment 8586064 [details] [review]
[gaia] albertopq:1149114-sim-landscape > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): -
[User impact] if declined: System dialogs are misplaced after entering in Fullscreen apps.
[Testing completed]: Unit tests
[Risk to taking this patch] (and alternatives if risky): Low risk patch. Just changing the event used, and with unit tests.
[String changes made]: -

Comment 16

[Ryan VanderMeulen [:RyanVM]]

I'm getting git bad object errors trying to cherry-pick this. Please provide a v2.2 PR.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

Managed to get it to apply by exporting the patch from github and applying via git-am.

v2.2: https://github.com/mozilla-b2g/gaia/commit/4e9beb11a9072149303df0592f07a7fc8d8f502b

Comment 18

[Ryan VanderMeulen [:RyanVM]]

Sigh, but then there were test failures. Reverted.
v2.2: https://github.com/mozilla-b2g/gaia/commit/f4151ddf587e1d86dc8970c855bcd8e30e369e9c

https://treeherder.mozilla.org/logviewer.html#?job_id=93721&repo=mozilla-b2g37_v2_2
https://treeherder.mozilla.org/logviewer.html#?job_id=93723&repo=mozilla-b2g37_v2_2

Comment 19

[Alberto Pastor [:albertopq]]

Apparently, it didn't land correctly in master:

master: https://github.com/mozilla-b2g/gaia/commit/b1632573bdf81c120038194590d23fae88104c20

I'll take a look to the failures in 2.2

Comment 20

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:1149114-uplift2 > mozilla-b2g:v2.2

Comment 21

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/fe5c34972de22d34b56377de118d572dbc9ab545

Comment 22

[Ryan VanderMeulen [:RyanVM]]

Same failures as before. Reverted.
v2.2: https://github.com/mozilla-b2g/gaia/commit/4a5b6f8e8b724c9525b16020bbe83a3d74930630

Comment 23

[Kevin Grandon :kgrandon]

This started causing a lot of intermittents in master as well, so we need to revert it there as well, sorry.

Master revert: https://github.com/mozilla-b2g/gaia/commit/af29b7755788ef03414298a3e298a936aefcbf53

Failures started here: https://treeherder.mozilla.org/#/jobs?repo=gaia-master&revision=b1632573bdf81c120038194590d23fae88104c20

Comment 24

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:1149114-sim-landscape2 > mozilla-b2g:master

Comment 25

[Alberto Pastor [:albertopq]]

Comment on attachment 8589151 [details] [review]
[gaia] albertopq:1149114-sim-landscape2 > mozilla-b2g:master

That should be fine now. Thanks!

Comment 26

[Kevin Grandon :kgrandon]

Comment on attachment 8589151 [details] [review]
[gaia] albertopq:1149114-sim-landscape2 > mozilla-b2g:master

Thanks!

Comment 27

[Alberto Pastor [:albertopq]]

master: https://github.com/mozilla-b2g/gaia/commit/1a7503addd99947e81085f7d296b184656a1079b

Comment 28

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:1149114-uplift2 > mozilla-b2g:v2.2

Comment 29

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/ea735c21bfb0d78333213ff0376fce1eac89ead6

Comment 30

[Elie]

This issue verified successfully·on flame 2.2&3.0
Flame 3.0:
Build ID               20150407160201
Gaia Revision          84cbd4391fb7175d5380fa72c04d68873ce77e6d
Gaia Date              2015-04-07 17:33:14
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/078128c2600a
Gecko Version          40.0a1
Device Name            flame
Firmware(Release)      4.4.2
Flame 2.2:
Build ID               20150407162504
Gaia Revision          ea735c21bfb0d78333213ff0376fce1eac89ead6
Gaia Date              2015-04-07 20:58:15
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/3f86ddb7f719
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2