Closed
Bug 1149136
Opened 9 years ago
Closed 9 years ago
Incorrect hover styling displayed for the article remove button available in the Reading List sidebar
Categories
(Firefox Graveyard :: Reading List, defect, P3)
Firefox Graveyard
Reading List
Tracking
(firefox38 verified, firefox39 fixed, firefox40 fixed)
VERIFIED
FIXED
Firefox 40
People
(Reporter: noni, Assigned: bwinton)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
921 bytes,
patch
|
florian
:
review+
mmaslaney
:
ui-review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Reproducible on: Nightly 39.0a1 (build ID: 20150329030238) Aurora 38.0a2 (build ID: 20150330004006) Affected platforms: Windows 7 64-bit, Windows 8.1 64-bit (Microsoft Surface Pro 2), Windows XP 64-bit, Ubuntu 14.04 32-bit and Mac OS X 10.9.5 Steps to reproduce: 1. Launch Firefox using a clean profile; 2. Make sure Reading list is enabled (browser.readinglist.enabled is set to true in about:config); 3. Visit several websites and add them to the Reading list; 4. Enable the Reading List sidebar (ctrl/cmd+alt+r) 5. Hover over the "Remove this from your Reading List" button. Expected Results: The "Remove this from your Reading List" is displayed. No glitches are seen. Actual Results: A line can be seen under the button (from the focus ring maybe). Screenshot: http://i.imgur.com/sWN8mb0.png
Comment 1•9 years ago
|
||
Wonder if this is as simple as a bad -moz-image-region or repeating image?
Priority: -- → P4
Comment 2•9 years ago
|
||
From bug 1149136: "Three small Close buttons are displayed instead of the desired one. Screenshot: http://i.imgur.com/hLPD3hF.png" (After adding a crash page from https://crash-stats.mozilla.com to the reading list.) I see a similar thing on OS X, with the button having two stacked images vertically. O_o http://cl.ly/image/2g1P1a151M2V That feels like a more serious glitch than just a subtle underline, so P3.
Priority: P4 → P3
Assignee | ||
Comment 3•9 years ago
|
||
Could this be related to (or fixed by) bug 1144774?
Assignee | ||
Comment 4•9 years ago
|
||
So, the problem is that the remove button, which is supposed to be 16px by 16px is actually 13.9px by 16px. Screenshot at https://dl.dropboxusercontent.com/u/2301433/firefox/Reading/CloseButtonV3.png
Assignee: nobody → bwinton
Status: NEW → ASSIGNED
Attachment #8589280 -
Flags: ui-review?(mmaslaney)
Attachment #8589280 -
Flags: review?(florian)
Updated•9 years ago
|
Attachment #8589280 -
Flags: ui-review?(mmaslaney) → ui-review+
Updated•9 years ago
|
Attachment #8589280 -
Flags: review?(florian) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 5•9 years ago
|
||
Comment on attachment 8589280 [details] [diff] [review] Set min height and width. Approval Request Comment [Feature/regressing bug #]: reading list [User impact if declined]: A confusing number of close buttons appear. See screenshots in comments 1 and 2. [Describe test coverage new/current, TreeHerder]: Manual. [Risks and why]: Very low. Minimal CSS-only change. [String/UUID change made/needed]: None.
Attachment #8589280 -
Flags: approval-mozilla-beta?
Attachment #8589280 -
Flags: approval-mozilla-aurora?
Comment 6•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/f6e1a21392c2
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Updated•9 years ago
|
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f6e1a21392c2
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 40
Updated•9 years ago
|
status-firefox38:
--- → affected
status-firefox39:
--- → affected
Comment 8•9 years ago
|
||
Comment on attachment 8589280 [details] [diff] [review] Set min height and width. Should be in 38 beta 4.
Attachment #8589280 -
Flags: approval-mozilla-beta?
Attachment #8589280 -
Flags: approval-mozilla-beta+
Attachment #8589280 -
Flags: approval-mozilla-aurora?
Attachment #8589280 -
Flags: approval-mozilla-aurora+
Assignee | ||
Updated•9 years ago
|
Points: --- → 1
Flags: needinfo?(bwinton)
Updated•9 years ago
|
Flags: qe-verify? → qe-verify+
Updated•9 years ago
|
QA Contact: andrei.vaida
Comment 12•9 years ago
|
||
Verified fixed on Beta 38.0b4-build1 (20150413143743), using Ubuntu 14.04 (x64), Windows 7 (x64), Windows 8.1 (x64) and Mac OS X 10.9.5.
Status: RESOLVED → VERIFIED
Updated•8 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•