1149136 - Incorrect hover styling displayed for the article remove button available in the Reading List sidebar

Status: VERIFIED FIXED

(Firefox Graveyard :: Reading List, defect, P3)

Description

[Cornel Ionce [:noni]]

Reproducible on:
Nightly 39.0a1 (build ID: 20150329030238)
Aurora 38.0a2 (build ID: 20150330004006)

Affected platforms:
Windows 7 64-bit, Windows 8.1 64-bit (Microsoft Surface Pro 2), Windows XP 64-bit, Ubuntu 14.04 32-bit and Mac OS X 10.9.5

Steps to reproduce:
1. Launch Firefox using a clean profile;
2. Make sure Reading list is enabled (browser.readinglist.enabled is set to true in about:config);
3. Visit several websites and add them to the Reading list;
4. Enable the Reading List sidebar (ctrl/cmd+alt+r)
5. Hover over the "Remove this from your Reading List" button.

Expected Results:
The "Remove this from your Reading List" is displayed. No glitches are seen.

Actual Results:
A line can be seen under the button (from the focus ring maybe).
Screenshot: http://i.imgur.com/sWN8mb0.png

Comment 1

[Justin Dolske [:Dolske]]

Wonder if this is as simple as a bad -moz-image-region or repeating image?

Comment 2

[Justin Dolske [:Dolske]]

From bug 1149136:

"Three small Close buttons are displayed instead of the desired one. Screenshot: http://i.imgur.com/hLPD3hF.png" (After adding a crash page from https://crash-stats.mozilla.com to the reading list.)

I see a similar thing on OS X, with the button having two stacked images vertically. O_o http://cl.ly/image/2g1P1a151M2V

That feels like a more serious glitch than just a subtle underline, so P3.

Comment 3

[Blake Winton (:bwinton) (:☕️)]

Could this be related to (or fixed by) bug 1144774?

Comment 4

[Blake Winton (:bwinton) (:☕️)]

Attachment: Set min height and width.

So, the problem is that the remove button, which is supposed to be 16px by 16px is actually 13.9px by 16px.

Screenshot at https://dl.dropboxusercontent.com/u/2301433/firefox/Reading/CloseButtonV3.png

Comment 5

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 8589280 [details] [diff] [review]
Set min height and width.

Approval Request Comment
[Feature/regressing bug #]: reading list
[User impact if declined]: A confusing number of close buttons appear.  See screenshots in comments 1 and 2.
[Describe test coverage new/current, TreeHerder]: Manual.
[Risks and why]: Very low.  Minimal CSS-only change.
[String/UUID change made/needed]: None.

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/f6e1a21392c2

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f6e1a21392c2

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8589280 [details] [diff] [review]
Set min height and width.

Should be in 38 beta 4.

Comment 9

[Marco Mucci [:MarcoM]]

Hi Blake, can you provide a point value.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0a74a003ca01

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0a9b3f3e962d

Comment 12

[Andrei Vaida [:avaida]]

Verified fixed on Beta 38.0b4-build1 (20150413143743), using Ubuntu 14.04 (x64), Windows 7 (x64), Windows 8.1 (x64) and Mac OS X 10.9.5.

Comment 13

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Removing qe-verify flag as it was verified on Firefox 38.