1149238 - [Product] Tracking bug for Marketplace Nav 2015 UAT

Status: RESOLVED FIXED

(Tracking Graveyard :: Marketplace, defect)

Description

[Stephanie Turner]

DBialer and PWalm,

Please verify Nav matches designs and functions as intended. Please make sure you sign off with a written comment once verified.

Comment 1

[Kevin Ngo [:ngoke]]

Nav is mostly done and visible on -dev, with a couple of polish bugs to be fixed soon.

Comment 2

[Kevin Ngo [:ngoke]]

This is primed to go out next Tuesday. Marking resolved to get it spot-checked and verified.

Comment 3

[Caitlin Galimidi [:c8o]]

Pwalm and DBialer

Is nav all ready to go?
Can you take a quick peek and clear out the need info with your comments?

Thanks muchly!!!
Caitlin

Comment 4

[Philip [:pwalm]]

- Looks like the type in the nav is using Fira Sans Light, it should be Regular weight.
- Spacing is off on the nav items, there should be even spacing between all elements.
- Clicking the search icon should toggle open/close of the search drawer. I click it to open, I should be able to click to close it. Same goes for User settings and Search.
- Strange spacing of menu items in mobile. "Recommended" has way more padding above and below.

Other than that, we're good to go!

Comment 5

[David Durst [:ddurst]]

(In reply to Philip [:pwalm] from comment #4)
> - Spacing is off on the nav items, there should be even spacing between all
> elements.

There is, between nav items. Do you mean between the rocket icon and Home, and between Categories and the magnifying glass also?


> - Clicking the search icon should toggle open/close of the search drawer. I
> click it to open, I should be able to click to close it. Same goes for User
> settings and Search.

This works for me. Can we get STR or what browser you're using?

> - Strange spacing of menu items in mobile. "Recommended" has way more
> padding above and below.

I also don't see this (on Flame 2.1).

Krupa, can you confirm these?

Comment 6

[Philip [:pwalm]]

- yes, even spacing between the rocket, all the text nav items and the mag glass.

- Weird. I was looking at the site using Firefox Developer Edition.

- One more thing! The User menu items are in the wrong order. It should be:

Settings | My Apps | Feedback | Sign out

Comment 7

[Kevin Ngo [:ngoke]]

Spacing: https://github.com/mozilla/fireplace/commit/d25e042a45a8bbfd4cb672efa9c7b2b4160911a8

Font weights: https://github.com/mozilla/fireplace/commit/f2c0b141603665aa9b1d6864f04fbb6bd3f6ba2f

User menu items: https://github.com/mozilla/fireplace/commit/202671c5ebf4f511215627a739b8ce22229de5f4

Comment 8

[Kevin Ngo [:ngoke]]

Search icon issue is resolved on -dev in this refactor: https://github.com/mozilla/fireplace/commit/d12933fe923f2089ffb6c8b71b8e07645f3038ef

Comment 9

[krupa raj[:krupa]]

This was shipped to prod today. All the issues were addressed.

Comment 10

[Caitlin Galimidi [:c8o]]

clearing on ni requests

Comment 11

[Terell]

I have left a few comments. I am not stalking or trying to cause any problems. Im just a married man try to find out if my wife is cheating or has been. My phones been hacked spied through yet here i sit alone everyday. So i just want the who when n wheres if so. So i can move on. Ty

Comment 12

[Terell]

Dont know what flags?

Comment 13

[Terell]

Angel lynette ransom ware