Closed Bug 1149247 Opened 6 years ago Closed 6 years ago

remove deprecated for-each-in loops in the account manager and account wizard

Categories

(MailNews Core :: Account Manager, defect)

defect
Not set
trivial

Tracking

(thunderbird40 fixed)

RESOLVED FIXED
Thunderbird 40.0
Tracking Status
thunderbird40 --- fixed

People

(Reporter: aceman, Assigned: aceman)

References

Details

Attachments

(1 file)

7.46 KB, patch
mkmelin
: review+
iann_bugzilla
: review+
ishikawa
: feedback+
BenB
: feedback+
Details | Diff | Splinter Review
No description provided.
Attached patch 1149247.patchSplinter Review
This should do it.
Attachment #8585634 - Flags: review?(mkmelin+mozilla)
Attachment #8585634 - Flags: review?(iann_bugzilla)
Attachment #8585634 - Flags: feedback?(ishikawa)
Attachment #8585634 - Flags: feedback?(ben.bucksch)
Comment on attachment 8585634 [details] [diff] [review]
1149247.patch

Review of attachment 8585634 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thx! r=mkmelin
Attachment #8585634 - Flags: review?(mkmelin+mozilla) → review+
Comment on attachment 8585634 [details] [diff] [review]
1149247.patch

I think your patch removed the issues.

However, as you may know, mozmill test does not seem to run on tryserver currently, so I can't verify my finding on local PC against what I find in other people's logs on tryserver.

TIA
Attachment #8585634 - Flags: feedback?(ishikawa) → feedback+
Attachment #8585634 - Flags: review?(iann_bugzilla) → review+
Comment on attachment 8585634 [details] [diff] [review]
1149247.patch

r+

Thanks!
Attachment #8585634 - Flags: feedback?(ben.bucksch) → feedback+
Thanks.
Keywords: checkin-needed
Version: unspecified → Trunk
https://hg.mozilla.org/comm-central/rev/5a56cda87f0f
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 40.0
You need to log in before you can comment on or make changes to this bug.