Closed
Bug 1149247
Opened 11 years ago
Closed 11 years ago
remove deprecated for-each-in loops in the account manager and account wizard
Categories
(MailNews Core :: Account Manager, defect)
MailNews Core
Account Manager
Tracking
(thunderbird40 fixed)
RESOLVED
FIXED
Thunderbird 40.0
| Tracking | Status | |
|---|---|---|
| thunderbird40 | --- | fixed |
People
(Reporter: aceman, Assigned: aceman)
References
Details
Attachments
(1 file)
No description provided.
This should do it.
Attachment #8585634 -
Flags: review?(mkmelin+mozilla)
Attachment #8585634 -
Flags: review?(iann_bugzilla)
Attachment #8585634 -
Flags: feedback?(ishikawa)
Attachment #8585634 -
Flags: feedback?(ben.bucksch)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8585634 [details] [diff] [review]
1149247.patch
Review of attachment 8585634 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good, thx! r=mkmelin
Attachment #8585634 -
Flags: review?(mkmelin+mozilla) → review+
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8585634 [details] [diff] [review]
1149247.patch
I think your patch removed the issues.
However, as you may know, mozmill test does not seem to run on tryserver currently, so I can't verify my finding on local PC against what I find in other people's logs on tryserver.
TIA
Attachment #8585634 -
Flags: feedback?(ishikawa) → feedback+
Attachment #8585634 -
Flags: review?(iann_bugzilla) → review+
|
||
Comment 4•11 years ago
|
||
Comment on attachment 8585634 [details] [diff] [review]
1149247.patch
r+
Thanks!
Attachment #8585634 -
Flags: feedback?(ben.bucksch) → feedback+
Thanks.
Keywords: checkin-needed
Version: unspecified → Trunk
|
||
Comment 6•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
status-thunderbird40:
--- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 40.0
You need to log in
before you can comment on or make changes to this bug.
Description
•