Closed Bug 1149277 Opened 8 years ago Closed 8 years ago

Increase the Line-Height in Reader View from 1.44 rem to 1.6 rem

Categories

(Firefox :: General, defect, P1)

Product:
Firefox
Component:
General
Version:
38 Branch
Platform:
x86
All
Type:
defect
Points:
1

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 40
Iteration:
40.1 - 13 Apr
Tracking Flags:
Tracking Status
firefox38 + fixed
firefox39 --- fixed
firefox40 --- fixed

People

(Reporter: mmaslaney, Assigned: bwinton)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The first version of the patch.
795 bytes, patch
Unfocused
: review+
mmaslaney
: ui-review+
Sylvestre
: approval-mozilla-aurora+
Sylvestre
: approval-mozilla-beta+
Details | Diff | Splinter Review 
Slight increasing the line-height within Reader View provides more contrast between the lines, and by doing so, makes it easier to read.

See spec:http://invis.io/892KPNSPV
Assignee: nobody → bwinton
How does this look, Michael?

(I've updated the build at https://dl.dropboxusercontent.com/u/2301433/Firefox/Reading/Transitions.dmg with the 1.6 line-height, if you wanted to test it.)
Attachment #8586253 - Flags: ui-review?(mmaslaney)
Attachment #8586253 - Flags: review?(bmcbride)
Comment on attachment 8586253 [details] [diff] [review]
The first version of the patch.

Gorgeous.
Attachment #8586253 - Flags: ui-review?(mmaslaney) → ui-review+
Status: NEW → ASSIGNED
Comment on attachment 8586253 [details] [diff] [review]
The first version of the patch.

Review of attachment 8586253 [details] [diff] [review]:
-----------------------------------------------------------------

Whoa, next time break these patches into smaller chunks, this is getting complex! ;)

(Why can't call bugs be like this?)
Attachment #8586253 - Flags: review?(bmcbride) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/6c24e4dec1ff
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: Firefox 38 → Firefox 40
Hi Blake, can you provide a point value.
Blocks: 1132074
Iteration: --- → 40.1 - 13 Apr
Flags: qe-verify?
Flags: needinfo?(bwinton)
Flags: firefox-backlog+
Is there anything smaller than 1 point?  ;)
Points: --- → 1
Flags: needinfo?(bwinton)
[Tracking Requested - why for this release]: Because the rest of reader mode landed in 38.

Uplift request:

[User impact if declined]: The text in reader mode will be slightly harder to read.
[Describe test coverage new/current, TBPL]: Manual testing, and baking on mozilla-central for two days.
[Risks and why]: Extremely low risk because its a single-line CSS change that only affects reading mode.
[String/UUID change made/needed]: none
tracking-firefox38: --- → ?
Comment on attachment 8586253 [details] [diff] [review]
The first version of the patch.

(I think bwinton meant to flip these flags)
Attachment #8586253 - Flags: approval-mozilla-beta?
Attachment #8586253 - Flags: approval-mozilla-aurora?
Comment on attachment 8586253 [details] [diff] [review]
The first version of the patch.

Should be in 38 beta 2
Attachment #8586253 - Flags: approval-mozilla-beta?
Attachment #8586253 - Flags: approval-mozilla-beta+
Attachment #8586253 - Flags: approval-mozilla-aurora?
Attachment #8586253 - Flags: approval-mozilla-aurora+
Doesn't look like something that would need dedicated attention from manual QA.
Flags: qe-verify? → qe-verify-
You need to log in before you can comment on or make changes to this bug.