Closed Bug 1149280 Opened 9 years ago Closed 9 years ago

Make nullprincipal creation faster

Categories

(Core :: Security, defect)

Product:
Core
Component:
Security
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla40
Tracking Flags:
Tracking Status
firefox40 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

part 1. Make nullprincipal creation faster
15.13 KB, patch
smaug
: review+
Details | Diff | Splinter Review
part 2. Drop the useless mScheme member of nsNullPrincipalURI
4.63 KB, patch
smaug
: review+
Details | Diff | Splinter Review 
The current setup is stupid.  We do the following:

1)  In nsScriptSecurityManager::CreateCodebasePrincipal we use the contractid instead of just creating a nullprincipal directly.

2)  In nsNullPrincipal we end up creating a URI string to pass to nsNullPrincipalURI, which then just parses it apart.  That's silly.
Attachment #8585860 - Flags: review?(bugs) → review+
Attachment #8585859 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/60d47f603817
https://hg.mozilla.org/mozilla-central/rev/c39ec40cb4e1
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.